chore: Remove is_valid checks from get_object_tags

openedx · Aug 14, 2023 · b9ba062 · b9ba062
1 parent 1992850
commit b9ba062
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 29 deletions.
diff --git a/openedx_tagging/core/tagging/api.py b/openedx_tagging/core/tagging/api.py
@@ -96,15 +96,12 @@ def resync_object_tags(object_tags: QuerySet = None) -> int:
 
 
 def get_object_tags(
-    object_id: str, taxonomy: Taxonomy = None, valid_only=True
-) -> Iterator[ObjectTag]:
+    object_id: str, taxonomy: Taxonomy = None
+) -> QuerySet:
     """
-    Generates a list of object tags for a given object.
+    Returns a Queryset of object tags for a given object.
 
     Pass taxonomy to limit the returned object_tags to a specific taxonomy.
-
-    Pass valid_only=False when displaying tags to content authors, so they can see invalid tags too.
-    Invalid tags will (probably) be hidden from learners.
     """
     ObjectTagClass = taxonomy.object_tag_class if taxonomy else ObjectTag
     tags = (
@@ -117,9 +114,7 @@ def get_object_tags(
     if taxonomy:
         tags = tags.filter(taxonomy=taxonomy)
 
-    for object_tag in tags:
-        if not valid_only or object_tag.is_valid():
-            yield object_tag
+    return tags
 
 
 def tag_object(

diff --git a/tests/openedx_tagging/core/tagging/test_api.py b/tests/openedx_tagging/core/tagging/test_api.py
@@ -427,37 +427,17 @@ def test_get_object_tags(self):
         assert list(
             tagging_api.get_object_tags(
                 object_id="abc",
-                valid_only=False,
             )
         ) == [
             alpha,
             beta,
         ]
 
-        # No valid tags for this object yet..
-        assert not list(
-            tagging_api.get_object_tags(
-                object_id="abc",
-                valid_only=True,
-            )
-        )
-        beta.tag = self.mammalia
-        beta.save()
-        assert list(
-            tagging_api.get_object_tags(
-                object_id="abc",
-                valid_only=True,
-            )
-        ) == [
-            beta,
-        ]
-
         # Fetch all the tags for a given object ID + taxonomy
         assert list(
             tagging_api.get_object_tags(
                 object_id="abc",
                 taxonomy=self.taxonomy,
-                valid_only=False,
             )
         ) == [
             beta,