-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add total descendant count to tag list APIs [FC-0036] #156
Add total descendant count to tag list APIs [FC-0036] #156
Conversation
Thanks for the pull request, @bradenmacdonald! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
372fd60
to
c212f17
Compare
c212f17
to
321a619
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 with one suggested change.
Once you address that and do a version bump, I think this is good to merge.
- I tested this on my devstack using Display full descendant count on taxonomy tag list page [FC-0036] frontend-app-authoring#826
- Navigated to the taxonomies list and selected a taxonomy
- Ensured that the descendant counts are showing as expected next to each tag in the tree.
- I read through the code
- I checked for accessibility issues by using my keyboard to navigate
- Includes documentation
-
User-facing strings are extracted for translationN/A
@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
This PR updates the APIs for retrieving the tags in the taxonomy, so that they state not only how many direct children they have, but also how many total descendants.
The direct children count is still included, not only to preserve backwards compatibility, but because it's necessary to compute pagination and display a "load more children" button when necessary.
What about performance of these queries? I ran the whole test suite before and after this change, which includes some very large taxonomies, and there was no measurable difference on average.
Ref: openedx/modular-learning#191
Private ref: FAL-3655
Note: needs a version bump when merged.