-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement ObjectTag retrieve REST API #68
feat: Implement ObjectTag retrieve REST API #68
Conversation
8008c1e
to
4c89229
Compare
Thanks for the pull request, @yusuf-musleh! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
2dbcb33
to
41e7034
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @yusuf-musleh , this is looking good.
I've requested one small change below, but once that's done it's good to go into CC review.
@bradenmacdonald could you have a look when you get a chance?
👍
- I tested this by running the edx-platform code from feat: Add retrieve object_tags REST API open-craft/edx-platform#577 with this branch installed. Created some object_tags using the shell, and checked that the REST API returned the expected data when queried.
- I read through the code
-
I checked for accessibility issuesN/A - Includes documentation for the added REST API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I just had one request about adding a test case, but you can also let me know if it's already covered somewhere else.
41e7034
to
f848861
Compare
83741de
to
1013db9
Compare
@yusuf-musleh Could you also please bump the patch version ? see openedx_learning/init.py |
Retrieve ObjectTags for given Object IDs, and optionally filter by taxonomy.
1013db9
to
0e6f12f
Compare
Yup! Just updated it. |
@yusuf-musleh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This PR implements the tagging REST API for retrieving object tags.
Adding/updating object tags will be handled in a subsequent PR.
Supporting Information
Testing instructions
Private-ref: FAL-3452