Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pyjwkest with pyjwt package #349

Merged
merged 4 commits into from
Jan 9, 2025
Merged

Conversation

mumarkhan999
Copy link
Member

@mumarkhan999 mumarkhan999 commented Apr 5, 2023

@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (44d0126) 97.84% compared to head (4455627) 97.75%.

Files Patch % Lines
lti_consumer/lti_1p3/tests/test_consumer.py 73.33% 4 Missing ⚠️
lti_consumer/plugin/views.py 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #349      +/-   ##
==========================================
- Coverage   97.84%   97.75%   -0.10%     
==========================================
  Files          77       77              
  Lines        6696     6649      -47     
==========================================
- Hits         6552     6500      -52     
- Misses        144      149       +5     
Flag Coverage Δ
unittests 97.75% <96.24%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mumarkhan999 mumarkhan999 force-pushed the umar/replace-jwkest-with-pyjwt branch from cf502f7 to 5a92149 Compare April 5, 2023 19:13
@mumarkhan999 mumarkhan999 force-pushed the umar/replace-jwkest-with-pyjwt branch 4 times, most recently from 0ee531d to 7ea43e5 Compare April 17, 2023 09:34
@mumarkhan999 mumarkhan999 force-pushed the umar/replace-jwkest-with-pyjwt branch from 7ea43e5 to 826a680 Compare April 27, 2023 09:36
@mumarkhan999 mumarkhan999 force-pushed the umar/replace-jwkest-with-pyjwt branch 3 times, most recently from 8039516 to 1585b78 Compare June 8, 2023 11:39
@mumarkhan999 mumarkhan999 force-pushed the umar/replace-jwkest-with-pyjwt branch 2 times, most recently from 92c7e10 to e7937f5 Compare June 21, 2023 13:33
@mumarkhan999 mumarkhan999 changed the title chore: add pyjwt requirement add pyjwt requirement Jun 22, 2023
@mumarkhan999 mumarkhan999 force-pushed the umar/replace-jwkest-with-pyjwt branch from e7937f5 to 1585b78 Compare June 23, 2023 10:15
@mumarkhan999 mumarkhan999 force-pushed the umar/replace-jwkest-with-pyjwt branch from 1585b78 to e33d723 Compare November 6, 2023 08:53
@mumarkhan999 mumarkhan999 force-pushed the umar/replace-jwkest-with-pyjwt branch 8 times, most recently from 633fb98 to 4455627 Compare January 17, 2024 08:59
@mumarkhan999 mumarkhan999 force-pushed the umar/replace-jwkest-with-pyjwt branch from 4455627 to 973aeac Compare August 13, 2024 07:09
@mumarkhan999 mumarkhan999 force-pushed the umar/replace-jwkest-with-pyjwt branch 6 times, most recently from ae80845 to 6e86631 Compare August 21, 2024 15:13
@mumarkhan999 mumarkhan999 force-pushed the umar/replace-jwkest-with-pyjwt branch from 6e86631 to 19494df Compare August 21, 2024 15:14
@mumarkhan999 mumarkhan999 force-pushed the umar/replace-jwkest-with-pyjwt branch 6 times, most recently from 9121ad3 to 0968e4b Compare September 19, 2024 06:43
@mumarkhan999 mumarkhan999 changed the title add pyjwt requirement Replace pyjwkest with pyjwt package Oct 3, 2024
@alangsto
Copy link
Contributor

alangsto commented Jan 2, 2025

@mumarkhan999 I was able to test these changes locally and can confirm that LTI launches are still working as expected.

@mumarkhan999 mumarkhan999 force-pushed the umar/replace-jwkest-with-pyjwt branch from 0968e4b to c030677 Compare January 8, 2025 10:12
@mumarkhan999
Copy link
Member Author

Thanks for the update @alangsto

@mumarkhan999 mumarkhan999 force-pushed the umar/replace-jwkest-with-pyjwt branch 5 times, most recently from b2e8366 to 6549014 Compare January 8, 2025 12:25
@mumarkhan999 mumarkhan999 force-pushed the umar/replace-jwkest-with-pyjwt branch from 6549014 to 8d63c76 Compare January 8, 2025 12:44
@alangsto alangsto merged commit 46cfc92 into master Jan 9, 2025
6 checks passed
@alangsto alangsto deleted the umar/replace-jwkest-with-pyjwt branch January 9, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants