Skip to content

Commit

Permalink
python3: skip readline limited history tests
Browse files Browse the repository at this point in the history
Python 3.12.5 is failing a newer ptest for reading/writing limited
history when editline (default) is set in PACKAGECONFIG. Skip it for now
until a proper fix (if any) is determined.

A bug has been opened upstream: python/cpython#123018

(From OE-Core rev: de569dd)

Signed-off-by: Trevor Gamblin <[email protected]>
Signed-off-by: Richard Purdie <[email protected]>
Signed-off-by: Peter Marko <[email protected]>
Signed-off-by: Steve Sakoman <[email protected]>
  • Loading branch information
threexc authored and sakoman committed Sep 18, 2024
1 parent ae0e8f6 commit 98b3a3e
Show file tree
Hide file tree
Showing 2 changed files with 42 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
From d9d916d5ea946c945323679d1709de1b87029b96 Mon Sep 17 00:00:00 2001
From: Trevor Gamblin <[email protected]>
Date: Tue, 13 Aug 2024 11:07:05 -0400
Subject: [PATCH] test_readline: skip limited history test

This test was added recently and is failing on the ptest image when
using the default PACKAGECONFIG settings (i.e. with editline instead of
readline).. Disable it until the proper fix is determined.

A bug has been opened upstream: https://github.com/python/cpython/issues/123018

Upstream-Status: Inappropriate [OE-specific]

Signed-off-by: Trevor Gamblin <[email protected]>
---
Lib/test/test_readline.py | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Lib/test/test_readline.py b/Lib/test/test_readline.py
index 91fd7dd13f9..d81f9bf8eed 100644
--- a/Lib/test/test_readline.py
+++ b/Lib/test/test_readline.py
@@ -132,6 +132,7 @@ def test_nonascii_history(self):
self.assertEqual(readline.get_history_item(1), "entrée 1")
self.assertEqual(readline.get_history_item(2), "entrée 22")

+ @unittest.skip("Skipping problematic test")
def test_write_read_limited_history(self):
previous_length = readline.get_history_length()
self.addCleanup(readline.set_history_length, previous_length)
@@ -349,6 +350,7 @@ def test_history_size(self):
self.assertEqual(len(lines), history_size)
self.assertEqual(lines[-1].strip(), b"last input")

+ @unittest.skip("Skipping problematic test")
def test_write_read_limited_history(self):
previous_length = readline.get_history_length()
self.addCleanup(readline.set_history_length, previous_length)
--
2.39.2

1 change: 1 addition & 0 deletions meta/recipes-devtools/python/python3_3.12.5.bb
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ SRC_URI = "http://www.python.org/ftp/python/${PV}/Python-${PV}.tar.xz \
file://0001-gh-107811-tarfile-treat-overflow-in-UID-GID-as-failu.patch \
file://0001-test_deadlock-skip-problematic-test.patch \
file://0001-test_active_children-skip-problematic-test.patch \
file://0001-test_readline-skip-limited-history-test.patch \
file://CVE-2024-7592.patch \
file://CVE-2024-8088.patch \
"
Expand Down

0 comments on commit 98b3a3e

Please sign in to comment.