Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update definitelytyped #3370

Merged
merged 1 commit into from
Sep 13, 2021
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 2, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@types/luxon 2.0.2 -> 2.0.3 age adoption passing confidence
@types/react 17.0.19 -> 17.0.20 age adoption passing confidence
@types/react-beautiful-dnd 13.1.1 -> 13.1.2 age adoption passing confidence

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot changed the title chore(deps): update dependency @types/react-beautiful-dnd to v13.1.2 chore(deps): update definitelytyped Sep 5, 2021
@renovate renovate bot force-pushed the renovate/definitelytyped branch 3 times, most recently from 3e7a8b8 to fc158b0 Compare September 7, 2021 06:17
@edalex-ian
Copy link
Member

Ah! Seeing @renovate-bot failed on package-lock.json it skips updating these. But because of the way NPM 7 now does deps it works for those GHA actions which use nvmrc, but not the functional tests where we've forgotten to explicitly set NPM version.

I think we really need to:

  1. Fix the GHA build for functional-testing to use NPM 7 like the rest of our build; and
  2. Figure out how to get the IntegTester to use lockfileVersion 2 for the cloud provider SDK - maybe with a TAR URL dependency type to address the git issue.

@renovate renovate bot force-pushed the renovate/definitelytyped branch 3 times, most recently from 9ad5b69 to 13ddcd4 Compare September 9, 2021 07:48
@edalex-ian
Copy link
Member

So this psc-package.exe persists @PenghaiZhang after your updates. However I think it's a different kettle of fish.

@edalex-ian
Copy link
Member

I think #3386 will fix this. So hopefully when that gets merged, this will get rebased, and all will be well again.

@renovate renovate bot merged commit b4f5610 into develop Sep 13, 2021
@renovate renovate bot deleted the renovate/definitelytyped branch September 13, 2021 12:10
@edalex-ian
Copy link
Member

Aww yeah! Things are mostly working again @PenghaiZhang 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants