Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OEL-2261: Override unformatted pattern for correct layout margins. #315

Open
wants to merge 1 commit into
base: 1.x
Choose a base branch
from
Open

OEL-2261: Override unformatted pattern for correct layout margins. #315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions templates/overrides/views/views-view-unformatted.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
{#
/**
* @file
* Template for a unformatted rows.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The english here is not correct, but I would change it completely to "Theme override to display a view of unformatted rows."

*/
#}
{% if title %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would the bcl heading template be suited here?

<h3>{{ title }}</h3>
{% endif %}
<div class="row row-cols-1 g-4">
{% for row in rows %}
{%
set row_classes = [
'col',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the result of this is not the same as mb-3, I checked, the spacing is not the same

default_row_class ? 'views-row',
]
%}
<div{{ row.attributes.addClass(row_classes) }}>
{{- row.content -}}
</div>
{% endfor %}
</div>
1 change: 0 additions & 1 deletion templates/patterns/card/pattern-card--variant-search.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@
'border-bottom',
'border-md-0',
'border-0',
'mb-3',
]}),
'text_color': 'dark',
'image': (image is not empty) ? image|merge({
Expand Down