Fix feedback from #87

This commit applies the feedback given in #87 and uses a flag to both add documentation and to match the style of the rest of the project. This change is only useful for exec healthchecks and not for http probes. Wherever possible users should only use http healthchecks since exec is very resource intensive. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
openfaas · Nov 28, 2019 · b6e635e · b6e635e
1 parent f846f56
commit b6e635e
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/main.go b/main.go
@@ -27,14 +27,21 @@ var (
 )
 
 func main() {
+	var runHealthcheck bool
+
+	flag.BoolVar(&runHealthcheck,
+		"run-healthcheck",
+		false,
+		"Check for the a lock-file, when using an exec healthcheck. Exit 0 for present, non-zero when not found.")
+
 	flag.Parse()
 
-	switch flag.Arg(0) {
-	case "healthcheck":
+	if runHealthcheck {
 		if lockFilePresent() {
 			os.Exit(0)
 		}
 
+		fmt.Fprintf(os.Stderr, "unable to find lock file.\n")
 		os.Exit(1)
 	}
 
@@ -367,6 +374,7 @@ func makeStaticRequestHandler(watchdogConfig config.WatchdogConfig) http.Handler
 
 func lockFilePresent() bool {
 	path := filepath.Join(os.TempDir(), ".lock")
+
 	if _, err := os.Stat(path); os.IsNotExist(err) {
 		return false
 	}