This repository has been archived by the owner on Mar 10, 2023. It is now read-only.
Add tests for cloning a git repo #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests will enable #615 to be worked on. Additional if guards are added through the tests. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
The faas-cli and watchdog are both available via Docker images which do not require curl to fetch them anymore. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
The whole response was being printed which was far too verbose for the purposes of logging. Fixes: #617 Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
alexellis
force-pushed
the
openfaasltd/test-git-clone
branch
from
89fe99e
to
78a9cce
Compare
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
If there's an error on basic auth, then return without trying to go further. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
|
Thanks @Waterdrips |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Ellis (OpenFaaS Ltd) [email protected]
Description
These tests will enable #615 to be worked on. Additional if
guards are added through the tests.
How Has This Been Tested?
Unit testing
How are existing users impacted? What migration steps/scripts do we need?
N/a