feat(abac-assertions): add context to assertion #112

jon-whit · 2023-11-01T17:38:38Z

Description

Add context to Assertions for ABAC support.

References

Review Checklist

I have clicked on "allow edits by maintainers".
I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
The correct base branch is being used, if not main
I have added tests to validate that the change in functionality is working as expected

* feat: add `condition` to RelationReference * feat: add `Condition` definition * feat: add `conditions` to AuthorizationModel * update swagger * feat: add `conditions` to WriteAuthorizationModelRequest * feat: add `context` fields to query requests * use an enum for condition param type names * add feat branch to review workflow * stick to enum conventions * suppress diffs from generated files * regenerate * add missing type name * proposed validation as starting point * add ipaddress type * tweaks * update validation for Condition.name * refactor: change Assertion TupleKey to CheckRequestTupleKey * feat: adding condition for tuple key (#94) * feat: adding condition for tuple key * remove redundant validation --------- Co-authored-by: Jonathan Whitaker <[email protected]> Co-authored-by: Adrian Tam <[email protected]>

* re-order fields on TupleKey * mark fields as required where applicable

Co-authored-by: José Padilla <[email protected]>

) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.12.0 to 0.17.0. - [Commits](golang/net@v0.12.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

miparnisari

Can you update the docs?

api/openfga/v1/openfga_service.proto

Lines 514 to 519 in 7f9be45

    
             description: 
        
               "The ReadAssertions API will return, for a given authorization model id, " 
        
               "all the assertions stored for it. An assertion is an object that contains a " 
        
               "tuple key, and the expectation of whether a call to the Check API of that tuple key " 
        
               "will return true or false. " 
        
           };

jpadilla and others added 15 commits September 14, 2023 13:03

feat(abac): update Write API to include a condition per tuple (#95)

2b2e5ac

fix: fix json interface for Write API (#96)

8bd5c66

fix: use snake case (#99)

c3a581f

Re-order tuple-related fields (#97)

dba5895

* re-order fields on TupleKey * mark fields as required where applicable

fix: set condition name to be condition_name in json

8def830

fix: reduce stutter in RelationshipCondition (#103)

e4bc967

chore: run workflow against base branch instead of always main (#105)

6484aa0

fix!: mark required fields as required (#104)

0fc8019

Co-authored-by: José Padilla <[email protected]>

feat: increase contextual tuple limit to 20 (#92)

7c84e50

fix: add missing newline in Read API (#93)

105d9e7

rebuild

9e3d648

Merge branch 'main' into feat/abac

fb9e0a8

feat(abac-assertions): add request context to Assertions

f12f739

jon-whit requested a review from a team as a code owner November 1, 2023 17:38

jon-whit changed the title ~~Add context to assertion~~ feat(abac-assertions): add context to assertion Nov 1, 2023

jon-whit changed the base branch from main to feat/abac November 1, 2023 17:40

miparnisari added the abac label Nov 30, 2023

miparnisari approved these changes Nov 30, 2023

View reviewed changes

miparnisari requested changes Nov 30, 2023

View reviewed changes

jpadilla marked this pull request as draft December 1, 2023 19:20

Base automatically changed from feat/abac to main December 1, 2023 19:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(abac-assertions): add context to assertion #112

feat(abac-assertions): add context to assertion #112

jon-whit commented Nov 1, 2023

miparnisari left a comment

	description:
	"The ReadAssertions API will return, for a given authorization model id, "
	"all the assertions stored for it. An assertion is an object that contains a "
	"tuple key, and the expectation of whether a call to the Check API of that tuple key "
	"will return true or false. "
	};

feat(abac-assertions): add context to assertion #112

Are you sure you want to change the base?

feat(abac-assertions): add context to assertion #112

Conversation

jon-whit commented Nov 1, 2023

Description

References

Review Checklist

miparnisari left a comment

Choose a reason for hiding this comment