Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add repository URL to pyproject.toml #138

Closed
wants to merge 1 commit into from
Closed

Add repository URL to pyproject.toml #138

wants to merge 1 commit into from

Conversation

bonjourmauko
Copy link
Member

@bonjourmauko bonjourmauko commented Mar 18, 2024 •
edited
Loading

Superseded by #139

  • Technical improvement
  • Details:
    • Add repository URL to pyproject.toml

MattiSG
MattiSG requested changes Mar 20, 2024
View reviewed changes
Copy link
Member

@MattiSG MattiSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then shouldn't issues and changelog also be updated to point to the country-template? 🤔

verbman
verbman reviewed Mar 20, 2024
View reviewed changes
Copy link
Contributor

@verbman verbman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've ended up taking a slightly different approach in PR 139 as it needs to account for the ./.bootstrap.sh script that replaces these contents when run to setup a new OpenFisca country template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@verbman verbman verbman left review comments

@MattiSG MattiSG MattiSG requested changes

Assignees
No one assigned
Labels
None yet
Projects
OpenFisca International
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bonjourmauko @MattiSG @verbman