Update references to setup.py
#142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was silent in https://github.com/openfisca/country-template/actions/runs/8810580013, which led to failed merge in #139
Upon initial setup, there might be no tag This entails a risk when a merge to main is made without a tag, but this is a workflow failure that is not supposed to happen
Ensure that a first version is tagged
verbman
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #139,
setup.pywas replaced bypyproject.toml.However, some workflow files were not updated to reflect that change. While correcting this problem, I identified another one where workflows fail after bootstrapping. This changeset:
setup.pyin the codebase.0.0.1upon bootstrapping, matching the value in the CHANGELOG.To be noted: this is the first PR towards
main, which currently is aligned withmaster. This pull request should thus, upon merge, trigger the deployment workflow. Since #139 changed the condition for deployment to being on themainbranch but the main branch was not updated, version 7.0.0 has still not been published.