-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix package upload on PyPi #144
Conversation
In the context of 2FA Requirement for PyPI beginning 2024-01-01, this PR fixes this CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sandcha! I'm surprised that the PYPI_TOKEN_OPENFISCA_BOT
secret is at repo level and not at organisation level. Unless it differs for each repository (which would be a good security practice), I'd find it more efficient to have it defined at org level 🙂 That's not blocking of course. The CHANGELOG is.
CHANGELOG.md
Outdated
@@ -1,6 +1,12 @@ | |||
# Changelog | |||
|
|||
## 7.0.0 [#139](https://github.com/openfisca/country-template/pull/139) | |||
### [#144](https://github.com/openfisca/country-template/pull/144) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a version number, or should be integrated in the 7.0.0
release (preferred, since 7.0.0 was not released anyway).
I'm personally in favour of simply dropping that change altogether from the changelog, as it does not impact reusers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, the ##
was here to say that we could expect a minor bump and then, I was waiting for the review to write the final version number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, didn't get that!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch on the version number indent!
Yes, here the I had hoped for a token per country or for the common/international repositories but it's note possible to group repositories on the PyPi website. So, for now, a GitHub repository has its own |
Co-authored-by: Matti Schneider <[email protected]>
HTTPError: 403 Forbidden
on package uploadThis PR needs:
OpenFisca Country-Template
project (the token is on theopenfisca-bot
account; we can find it on the settings page)PYPI_TOKEN_OPENFISCA_BOT
in this repository secretsThese changes: