Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: test built version #158

Merged
merged 8 commits into from
Oct 18, 2024
Merged

build: test built version #158

merged 8 commits into from
Oct 18, 2024

Conversation

bonjourmauko
Copy link
Member

@bonjourmauko bonjourmauko commented Oct 16, 2024

Part of openfisca/openfisca-core#1064
Depends on #156

  • Technical Changes
  • Details:
    • Run tests in absolute isolation
      • Uses tox to test builds in isolation

@bonjourmauko bonjourmauko added the kind:build Changes that affect the build system or external dependencies label Oct 16, 2024
@bonjourmauko bonjourmauko self-assigned this Oct 16, 2024
@bonjourmauko bonjourmauko marked this pull request as ready for review October 16, 2024 13:19
@bonjourmauko bonjourmauko requested review from verbman and a team October 16, 2024 13:20
@bonjourmauko bonjourmauko changed the base branch from main to build/normalize-pyproject October 16, 2024 13:21
Base automatically changed from build/normalize-pyproject to main October 16, 2024 13:24
Copy link
Contributor

@benoit-cty benoit-cty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the work.

Maybe it will be nice to add some installation instructions in the contributing.md :

You need to have tox and Python 3.9 to run test like the CI does :

# Install PyEnv
curl https://pyenv.run | bash
# Install Python 3.9 needed by tox
pyenv install 3.9.20
# Install pipx
sudo apt install pipx
# Install tox
pipx install tox

Run lint with tox -r -e lint
Run test with tox -r -e py39

Makefile Outdated Show resolved Hide resolved
@bonjourmauko bonjourmauko merged commit de83b9e into main Oct 18, 2024
6 checks passed
@bonjourmauko bonjourmauko deleted the ci/test-built branch October 18, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:build Changes that affect the build system or external dependencies
Projects
Development

Successfully merging this pull request may close these issues.

2 participants