Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shift from file-based configuration to environment variables #165

Merged
merged 30 commits into from
Aug 9, 2018
Merged

Shift from file-based configuration to environment variables #165

merged 30 commits into from
Aug 9, 2018
+1,862 −2,104

Commits on Aug 9, 2018

  1. Unify import statements order 

    Group by distance: first group is for app imports, second group for dependencies, third group for standard library
    @MattiSG
    MattiSG committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    b58f1bf View commit details
    Browse the repository at this point in the history

  2. Remove almost unused winston dependency 

    Remove winstonConfig config element
    @MattiSG
    MattiSG committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    2f4984d View commit details
    Browse the repository at this point in the history

  3. Rename piwikConfig config key to matomo 

    Remove redundant “config” suffix
Piwik renamed to Matomo in 2018
    @MattiSG
    MattiSG committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    1d42e6c View commit details
    Browse the repository at this point in the history

  4. Remove unused useCommitReferenceFromApi config key

    @MattiSG
    MattiSG committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    452ff56 View commit details
    Browse the repository at this point in the history

  5. Load host and port through env variables only 

    Define default values and load actual ones in a single place
    @MattiSG
    MattiSG committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    86b7d39 View commit details
    Browse the repository at this point in the history

  6. Unify webpack dev server host and port definition 

    Document the options
    @MattiSG
    MattiSG committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    eae5169 View commit details
    Browse the repository at this point in the history

  7. Support setting API URL in a single place 

    Document default API URL value
    @MattiSG
    MattiSG committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    09adf4d View commit details
    Browse the repository at this point in the history

  8. Replace githubProject config key with changelogUrl 

    This property was not used in any other place and was only used for this inference. Decrease vendor lock-in.
    @MattiSG
    MattiSG committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    48dd346 View commit details
    Browse the repository at this point in the history

  9. Fix whitespace

    @MattiSG
    MattiSG committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    223c7b4 View commit details
    Browse the repository at this point in the history

  10. Improve env variable usage documentation

    @MattiSG
    MattiSG committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    955a70b View commit details
    Browse the repository at this point in the history

  11. Remove gitWebpageUrl config key 

    Does not variate for each instance, depends on the legislation explorer itself
    @MattiSG
    MattiSG committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    52e0f7a View commit details
    Browse the repository at this point in the history

  12. Remove unused websiteUrl config key 

    Does not variate for each instance, was already not used anymore
    @MattiSG
    MattiSG committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    8e00b10 View commit details
    Browse the repository at this point in the history

  13. Support Matomo config through env variables

    @MattiSG
    MattiSG committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    3b23a12 View commit details
    Browse the repository at this point in the history

  14. Support defining UI strings through env variable

    @MattiSG
    MattiSG committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    920dab8 View commit details
    Browse the repository at this point in the history

  15. Get dev assets base URL from webpack dev config

    @MattiSG
    MattiSG committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    aa32fc3 View commit details
    Browse the repository at this point in the history

  16. Drop support for file-based configuration

    @MattiSG
    MattiSG committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    0e3848b View commit details
    Browse the repository at this point in the history

  17. Use Node API name for URL pathname

    @MattiSG
    MattiSG committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    6c99b6a View commit details
    Browse the repository at this point in the history

  18. Properly pass NODE_ENV to frontend

    @MattiSG
    MattiSG committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    ee974a6 View commit details
    Browse the repository at this point in the history

  19. Support .env files

    @MattiSG
    MattiSG committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    cbca978 View commit details
    Browse the repository at this point in the history

  20. Refactor .gitignore

    @MattiSG
    MattiSG committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    fd44a22 View commit details
    Browse the repository at this point in the history

  21. Limit .env files support only through NPM scripts 

    The current loading mechanism loads the config file in the frontend too, which fails to compile dotenv into a frontend bundle.
    @MattiSG
    MattiSG committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    fea8d83 View commit details
    Browse the repository at this point in the history

  22. Fix typo

    @MattiSG
    MattiSG committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    a11fc1e View commit details
    Browse the repository at this point in the history

  23. Derive webpack dev server host and port from app's 

    Remove unnecessary complexity. When in dev mode, it is expected that user has full port definition freedom and can accomodate for finding two subsequent available ports.
    @MattiSG
    MattiSG committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    581b2bc View commit details
    Browse the repository at this point in the history

  24. Improve error behaviour in webpack dev server boot

    @MattiSG
    MattiSG committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    dd252bd View commit details
    Browse the repository at this point in the history

  25. Support dotenv variables in webpack config 

    Define config in a single place
    @MattiSG
    MattiSG committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    871ff98 View commit details
    Browse the repository at this point in the history

  26. Simplify documentation minor

    @MattiSG
    MattiSG committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    fbf02e4 View commit details
    Browse the repository at this point in the history

  27. List all available env vars in .env.example

    @MattiSG
    MattiSG committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    8891c19 View commit details
    Browse the repository at this point in the history

  28. Ensure config is always forwarded to frontend

    @MattiSG
    MattiSG committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    8bdb23a View commit details
    Browse the repository at this point in the history

  29. Clean up unused import

    @MattiSG
    MattiSG committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    9d74fec View commit details
    Browse the repository at this point in the history

  30. Remove France-specific autodeploy 

    Would trigger a failed build on production on merge. Will have to be updated to support the latest config system as documented in the PR.
    @MattiSG
    MattiSG committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    5da4e75 View commit details
    Browse the repository at this point in the history