Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Matti Schneider <[email protected]>
  • Loading branch information
2 people authored and Mauko Quiroga committed Oct 7, 2021
1 parent 841f852 commit b1dc1d8
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
12 changes: 6 additions & 6 deletions openfisca_tasks/lint.mk
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
## Lint the codebase.
lint: check-syntax-errors check-style lint-styling-doc check-types
lint: check-syntax-errors check-style lint-doc check-types
@$(call print_pass,$@:)

## Compile python files to check for syntax errors.
Expand All @@ -15,18 +15,18 @@ check-style: $(shell git ls-files "*.py")
@$(call print_pass,$@:)

## Run linters to check for syntax and style errors in the doc.
lint-styling-doc: \
lint-styling-doc-commons \
lint-styling-doc-types \
lint-doc: \
lint-doc-commons \
lint-doc-types \
;

## Run linters to check for syntax and style errors in the doc.
lint-styling-doc-%:
lint-doc-%:
@## These checks are exclusively related to doc/strings/test.
@##
@## They can be integrated into setup.cfg once all checks pass.
@## The reason they're here is because otherwise we wouldn't be
@## able to integrate documentation improvements progresively.
@## able to integrate documentation improvements incrementally.
@##
@## D101: Each class has to have at least one doctest.
@## D102: Each public method has to have at least one doctest.
Expand Down
4 changes: 2 additions & 2 deletions setup.cfg
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
; DXXX: http://www.pydocstyle.org/en/2.1.1/error_codes.html#grouping.
; DXXX: We do not (yet) check docstrings (see https://www.pydocstyle.org/en/2.1.1/error_codes.html#grouping).
; DAR101: We do not (yet) document class/function attributes/arguments.
; DAR201: We do not (yet) document method/function returns.
; E128/133: We prefer hang-closing visual indents.
Expand Down Expand Up @@ -26,7 +26,7 @@ enable = C0116,R0401
score = no

[tool:pytest]
addopts = --cov-report=term-missing:skip-covered --cov-fail-under=78.50 --doctest-modules --disable-pytest-warnings --showlocals
addopts = --cov-report=term-missing:skip-covered --doctest-modules --disable-pytest-warnings --showlocals
doctest_optionflags = ELLIPSIS IGNORE_EXCEPTION_DETAIL NUMBER NORMALIZE_WHITESPACE
python_files = **/*.py
testpaths = openfisca_core/commons tests
Expand Down

0 comments on commit b1dc1d8

Please sign in to comment.