Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Makefile #1036

Merged
merged 3 commits into from
Aug 31, 2021
Merged

Document Makefile #1036

merged 3 commits into from
Aug 31, 2021

Conversation

bonjourmauko
Copy link
Member

Non-technical changes

  • Document Makefile
    • Add a comment to explain what each task does
    • Print a human friendly message when running a task
$ make test

[⚙] Delete builds and compiled python files...
[⚙] Compile python files to check for syntax errors...
[⚙] Run linters to check for syntax and style errors...
[⚙] Run static type checkers for type errors...
Success: no issues found in 131 source files
[⚙] Run openfisca-core tests...
...

@bonjourmauko bonjourmauko added the kind:docs Add or improvement of documentation label Aug 25, 2021
@bonjourmauko bonjourmauko requested a review from a team August 25, 2021 11:48
@benjello
Copy link
Member

@maukoquiroga : Looks useful although I cannot review the code ... sorry.
cc @HAEKADI @MattiSG

Copy link
Contributor

@HAEKADI HAEKADI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the addition @maukoquiroga 👍 The file is much clearer now :)

I tested the commands locally and they're all functional!

@bonjourmauko bonjourmauko merged commit bdcad8e into master Aug 31, 2021
@bonjourmauko bonjourmauko deleted the doc-make branch August 31, 2021 17:33
@HAEKADI
Copy link
Contributor

HAEKADI commented Sep 1, 2021

@maukoquiroga Should we do the same for OpenFisca-France and Country-Template?
It might also be a good opportunity to address these issues 🤔
cc @MattiSG

@MattiSG
Copy link
Member

MattiSG commented Sep 1, 2021

Should we not deprecate the Makefile entirely and replace it with a task runner that's less obsolete? 😅

@bonjourmauko
Copy link
Member Author

Hello @MattiSG, I'm personally agnostic as I like make a lot.

However, I've been looking for pure Python alternatives, for these reasons:

  • It's Python, so easier to maintain and test
  • It's Python, so we can avoid the bash, zch, Windows limitations

There are two alternatives that look promising to me, invoke and nox.

Please do not hesitate to open an issue if you think it would be worth the effort 😃

@MattiSG
Copy link
Member

MattiSG commented Sep 1, 2021

Thanks @maukoquiroga! “nox is a command-line tool that automates testing in multiple Python environments” while “Invoke is a Python task execution tool & library”, so it seems only Invoke would be appropriate, no? 🙂

@bonjourmauko
Copy link
Member Author

Yes, I mixed two different use cases. Take a look at it, it looks pretty awesome as a make replacement to me at least.

@bonjourmauko
Copy link
Member Author

@maukoquiroga Should we do the same for OpenFisca-France and Country-Template?
It might also be a good opportunity to address these issues 🤔
cc @MattiSG

Sorry @HAEKADI I completed missed this comment. Taking a look at the link now :)

@bonjourmauko
Copy link
Member Author

I think make is not the best tool for dependency management. I'm not fully convinced by poetry but in #1015 I try to simplify things already just with setuptools, I'd appreciate your feedback :)

bonjourmauko pushed a commit that referenced this pull request Sep 7, 2021
Merge pull request #1036 from openfisca/doc-make
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:docs Add or improvement of documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants