Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No importlib metadata #1178

Merged
merged 6 commits into from
Dec 19, 2022
Merged

No importlib metadata #1178

merged 6 commits into from
Dec 19, 2022

Conversation

eraviart
Copy link
Member

@eraviart eraviart commented Dec 19, 2022 •
edited
Loading

Technical changes

@coveralls
Copy link

coveralls commented Dec 19, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.004%) to 77.664% when pulling 2eac703 on no_importlib_metadata into 441adac on master.

@eraviart eraviart requested review from bonjourmauko, MattiSG and benjello and removed request for bonjourmauko and MattiSG December 19, 2022 15:08
@eraviart eraviart marked this pull request as ready for review December 19, 2022 15:19
@eraviart eraviart merged commit f7529a2 into master Dec 19, 2022
@eraviart eraviart deleted the no_importlib_metadata branch December 19, 2022 15:24
bonjourmauko added a commit that referenced this pull request Dec 19, 2022
@bonjourmauko
Revert "Remove use of importlib_metadata (#1178)"
90d473e 
This reverts commit f7529a2, reversing
changes made to 441adac.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjello benjello benjello approved these changes

@bonjourmauko bonjourmauko Awaiting requested review from bonjourmauko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing importlib_metadata requirement
3 participants
@eraviart @coveralls @benjello