docs: fix doc & type definitions in the projectors module #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonjourmauko
added
level:starter
bonjourmauko
force-pushed
the
fix-mypy-checks-ent
branch
from
7df2f45
to
3b0246b
Compare
bonjourmauko
force-pushed
the
fix-mypy-chekcs-proj
branch
from
7038fff
to
c8e1271
Compare
bonjourmauko
force-pushed
the
fix-mypy-checks-ent
branch
3 times, most recently
from
d2960a8
to
a7904e5
Compare
bonjourmauko
force-pushed
the
fix-mypy-chekcs-proj
branch
from
c8e1271
to
49400fc
Compare
bonjourmauko
force-pushed
the
fix-mypy-checks-ent
branch
2 times, most recently
from
33465fc
to
7b37709
Compare
bonjourmauko
force-pushed
the
fix-mypy-chekcs-proj
branch
from
49400fc
to
54126d6
Compare
Draft
bonjourmauko
changed the title
bonjourmauko
changed the base branch from
fix-mypy-checks-ent
to
fix-mypy-checks-periods
bonjourmauko
force-pushed
the
fix-mypy-chekcs-proj
branch
from
54126d6
to
ebd3829
Compare
bonjourmauko
force-pushed
the
fix-mypy-checks-periods
branch
from
3601736
to
9317b7f
Compare
bonjourmauko
force-pushed
the
fix-mypy-checks-enums
branch
from
d53f125
to
4a99cb4
Compare
bonjourmauko
force-pushed
the
fix-mypy-chekcs-proj
branch
from
57d74a0
to
584e97f
Compare
bonjourmauko
force-pushed
the
fix-mypy-checks-enums
branch
from
4a99cb4
to
dad88a1
Compare
32 tasks
benoit-cty
reviewed
Sep 27, 2024
openfisca_core/commons/types.py
Outdated
There was a problem hiding this comment.
Why re-creating types here instead of importing them directly ?
There was a problem hiding this comment.
I'm still unsure what is the best way to go.
bonjourmauko
force-pushed
the
fix-mypy-checks-enums
branch
from
25cb01f
to
2b24884
Compare
bonjourmauko
changed the title
bonjourmauko
added
kind:docs
bonjourmauko
force-pushed
the
fix-mypy-checks-enums
branch
2 times, most recently
from
83e521c
to
738652a
Compare
bonjourmauko
force-pushed
the
fix-mypy-checks-enums
branch
from
738652a
to
c54d3a5
Compare
bonjourmauko
changed the base branch from
fix-mypy-checks-enums
to
docs/add-docs-to-experimental
benjello
reviewed
Oct 14, 2024
| @@ -125,7 +141,7 @@ def period(value) -> Period: | |||
| Period((<DateUnit.DAY: 'day'>, Instant((2021, 1, 1)), 1)) | |||
|
|
|||
| >>> period(DateUnit.ETERNITY) | |||
| Period((<DateUnit.ETERNITY: 'eternity'>, Instant((1, 1, 1)), inf)) | |||
| Period((<DateUnit.ETERNITY: 'eternity'>, Instant((1, 1, 1)), 0)) | |||
benjello
reviewed
Oct 14, 2024
| @@ -164,15 +180,9 @@ def period(value) -> Period: | |||
| return Period((DateUnit.DAY, instant(value), 1)) | |||
|
|
|||
| # We return an "eternity-period", for example | |||
| # ``<Period(('eternity', <Instant(1, 1, 1)>, inf))>``. | |||
| # ``<Period(('eternity', <Instant(1, 1, 1)>, 0))>``. | |||
bonjourmauko
force-pushed
the
docs/add-docs-to-experimental
branch
2 times, most recently
from
0da8886
to
0e10d12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1239
Depends on #1224
Depended upon by #1146
Technical changes