-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract axes from SimulationBuilder #996
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not an expert but it looks cleaner than before therefore I have no objection.
Thanks @benjello, to be more clear what I would like is to know if the assumptions I'm doing are the right ones in terms of field expertise. For example:
Most of the intent is not yet implemented but outlined in the documentation. |
|
Thanks @benjello, this is not yet ready to be merged, I wanted to be sure I was shooting at the right direction.
So we could have, for example, something like:
But no:
? |
This is a work in progress based on my willingness to give a proper answer to #933 and #934.
I hoped to have a more advanced proposal for a request for comments, but axes are a hard one to tackle properly.
What do you think? Any feedback at this point @benjello @guillett?
Details below.
New features
Axis
,AxisArray
, andAxisExpander
.Improvements
Deprecations
add_parallel_axis
,add_perpendicular_axis
, andexpand_axes
.AxisArray
andAxisExpander
.