Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3333 - User fix and translate title #3461

Merged
merged 8 commits into from
Feb 3, 2024
Merged

3333 - User fix and translate title #3461

merged 8 commits into from
Feb 3, 2024

Conversation

yaguzmang
Copy link
Contributor

@yaguzmang yaguzmang commented Jan 31, 2024 •
edited
Loading

DB after running migration:
image

UI:

  • Translations working for all languages, and changing title while in any given language works:
2024-01-31.19-26-59.mp4
  • User country role selector updated, since it also uses the SelectField from EditUserForm:
    image

Closes #3333

@yaguzmang yaguzmang self-assigned this Feb 1, 2024
@yaguzmang yaguzmang marked this pull request as ready for review February 1, 2024 00:34
@yaguzmang yaguzmang changed the title 3333 user fix and translate title 3333 - User fix and translate title Feb 1, 2024
@yaguzmang yaguzmang requested a review from sorja February 1, 2024 00:37
minotogna
minotogna reviewed Feb 2, 2024
View reviewed changes
Copy link
Member

@minotogna minotogna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the contacts form use the new useOptionsAppellation hook ?

src/client/components/EditUserForm/SelectField/SelectField.tsx Show resolved Hide resolved
src/client/components/EditUserForm/UserCountryRoleSelector/hooks/useOptions.tsx Outdated Show resolved Hide resolved
src/test/migrations/steps/20240130202403-step-fix-user-tittle.ts Show resolved Hide resolved
@mergify mergify bot merged commit ad04296 into development Feb 3, 2024
5 checks passed
@mergify mergify bot deleted the 3333-user-fix-and-translate-title branch February 3, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minotogna minotogna minotogna approved these changes

@sorja sorja Awaiting requested review from sorja

Assignees

@yaguzmang yaguzmang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User: Fix and translate Title
3 participants
@yaguzmang @minotogna @sorja