4001 - Datatable use Datagrid - Add first col sticky #4202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaguzmang
commented
Jan 9, 2025
src/client/pages/Section/DataTable/Table/RowData/Cell/Cell.scss
Outdated
Show resolved
Hide resolved
minotogna
reviewed
Jan 9, 2025
| @@ -14,6 +14,7 @@ | |||
|
|
|||
| .table-grid-container { | |||
| margin-bottom: 28px; | |||
| overflow-x: auto; | |||
There was a problem hiding this comment.
Didn't we add it already some place
Else ?
There was a problem hiding this comment.
Yes, we have it in table-grid-container so it doesn't stretch the page and in table-grid, so that it's only the grid moving and not the buttons:
2025-01-09.14-55-38.mp4
It's a bit different now that I removed some of the fra table wrapper divs.
minotogna
reviewed
Jan 10, 2025
| return { | ||
| firstHeaderRowSpan, |
There was a problem hiding this comment.
I understand this, it's a fix just for the first column . Let's talk later about this
minotogna
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
2025-01-08.23-20-31.mp4