Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove shpinx as direct dependency #945

Merged
merged 2 commits into from
Sep 20, 2024
Merged

ci: remove shpinx as direct dependency #945

merged 2 commits into from
Sep 20, 2024

Conversation

dfguerrerom
Copy link
Collaborator

Aims to close #944 by removing the direct dependency and just installing the latest release.

Let's the tests see if it works.

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.47%. Comparing base (08b4d25) to head (8885d70).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #945   +/-   ##
=======================================
  Coverage   96.47%   96.47%           
=======================================
  Files          39       39           
  Lines        4002     4002           
=======================================
  Hits         3861     3861           
  Misses        141      141           
Flag Coverage Δ
96.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dfguerrerom dfguerrerom marked this pull request as ready for review September 20, 2024 16:01
@dfguerrerom dfguerrerom merged commit 9163dbb into main Sep 20, 2024
8 checks passed
@dfguerrerom dfguerrerom deleted the sphinx branch September 20, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I cannot release in pypip
2 participants