Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹(api schema): add course query param to product retrieve route #231

Closed
wants to merge 2 commits into from

Conversation

rlecellier
Copy link
Collaborator

Purpose

course is a mandatory query param for product.retrieve. we need it in order to correctly generate javascript api client.

@rlecellier rlecellier force-pushed the rlecellier/generate_api_client branch 2 times, most recently from 7f58b6a to 3e65532 Compare February 28, 2023 09:43
course is a mandatory query param for product.retrieve.
we need it in order to correctly generate javascript api client.
... for OrderViewSet

Each viewset endpoints take and send differentes values.
It's currently defined as Order for all ViewSet endpoints.

Here we specify which data will be given in the request body
and which data will be sent as response.
@rlecellier
Copy link
Collaborator Author

dupliated here

@rlecellier rlecellier closed this Mar 1, 2023
@sampaccoud sampaccoud deleted the rlecellier/generate_api_client branch September 29, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant