🚚(celery) rename celery tasks by adding a _task suffix #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunika
reviewed
Oct 15, 2024
There was a problem hiding this comment.
IMO Having a task module containing tasks will be more relevant than using a suffix.
Something like mork.celery.tasks.deletion.
Morever, right now you already have the information in the modules name that you are working with tasks (deletion_tasks and emailing_tasks), so the information is reduntant
wilbrdt
force-pushed
the
remove-username
branch
from
b054b65
to
592b4e1
Compare
Relocating and renaming tasks files `deletion_tasks` and `emailing_tasks` to `tasks.deletion` and `tasks.emailing`. Renaming `delete_user` utility function to `delete_user_from_db`. Renaming `deletion_task` task function to `delete_user`. Renaming `send_email` task function to `warn_user`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
deletion_tasksandemailing_taskstotasks.deletionandtasks.emailing.delete_userutility function todelete_user_from_db.deletion_tasktask function todelete_user.send_emailtask function towarn_user.