🐛(edx) fix mysql seeding script for development #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `student_manualenrollmentaudit` table is a child of the `student_coursenrollment` table, which is a child of the `auth_user` table. When a user is deleted, Mork should delete the corresponding enrollments and the corresponding manual enrollment audits. We don't want to delete based on the `enrolled_by` field.
Since the introduction of the edx MySQL models, the seeding script has stopped working. We rely on factories to generate fake data into the MySQL development database. To ensure compatibility with both testing and seeding use cases, the factories need some proper configuration, mainly on handling the session and the persistency. Additionally, subfactories were used to cascade factory creation, which works in tests but fails when committing to a real development database. These subfactories have been replaced with factoryboy related factories to resolve the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
student_manualenrollmentauditare incorrect.Proposal
student_manualenrollmentaudittable is a child of thestudent_coursenrollmenttable, which is a child of theauth_usertable. When a user is deleted, Mork should delete the corresponding enrollments and the corresponding manual enrollment audits. We don't want to delete based on theenrolled_byfieldAdditionally, subfactories were used to cascade factory creation, which works in tests but fails when committing to a real development database. These subfactories have been replaced with factoryboy related factories to resolve the issue.