Skip to content

Commit

Permalink
🚨(backend) migrate to pylint 3.3.x
Browse files Browse the repository at this point in the history
Since pylint 3.3.x, a new error is raised in our codebase
"too-many-positional-arguments" so we update our codebase to fix that.
  • Loading branch information
jbpenrath committed Sep 30, 2024
1 parent 5d8062e commit ea63d71
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion src/richie/apps/core/factories.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
from ..core.helpers import create_i18n_page, get_permissions


# pylint: disable=too-many-arguments
# pylint: disable=too-many-arguments,too-many-positional-arguments
def create_text_plugin(
page,
slot,
Expand Down
6 changes: 3 additions & 3 deletions src/richie/apps/courses/templatetags/extra_tags.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
register = template.Library()


# pylint: disable=too-many-arguments
# pylint: disable=too-many-arguments,too-many-positional-arguments
def get_plugins_render_tag(
context, name, varname, nodelist, page_lookup=None, edit=True
):
Expand Down Expand Up @@ -97,7 +97,7 @@ class PlaceholderAsPlugins(Placeholder):
blocks=[("endplaceholder_as_plugins", "nodelist")],
)

# pylint: disable=arguments-renamed,too-many-arguments
# pylint: disable=arguments-renamed,too-many-arguments,too-many-positional-arguments
def render_tag(self, context, name, varname, extra_bits, nodelist=None):
return get_plugins_render_tag(context, name, varname, nodelist)

Expand Down Expand Up @@ -148,7 +148,7 @@ class GetPlaceholderPlugins(Tag):
blocks=[("endget_placeholder_plugins", "nodelist")],
)

# pylint: disable=arguments-differ,too-many-arguments, unused-argument
# noqa pylint: disable=arguments-differ,too-many-arguments,unused-argument,too-many-positional-arguments
def render_tag(
self, context, name, page_lookup, varname, extra_bits, nodelist=None
):
Expand Down
2 changes: 1 addition & 1 deletion src/richie/apps/demo/helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from richie.apps.courses.factories import CategoryFactory


# pylint: disable=too-many-arguments
# pylint: disable=too-many-arguments,too-many-positional-arguments
def create_categories(
children=None,
color=None,
Expand Down
2 changes: 1 addition & 1 deletion src/richie/apps/search/filter_definitions/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class BaseFilterDefinition:

SORTING_CONF, SORTING_COUNT, SORTING_NAME = "conf", "count", "name"

# pylint: disable=too-many-arguments
# pylint: disable=too-many-arguments,too-many-positional-arguments
def __init__(
self,
name,
Expand Down

0 comments on commit ea63d71

Please sign in to comment.