♿(templates) fix organization glimpse #2512
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandroscosta
force-pushed
the
sandroscosta/a11y/fix-organization-glipmse
branch
from
695e1c8
to
e531176
Compare
jbpenrath
approved these changes
Oct 14, 2024
sandroscosta
changed the title
sandroscosta
force-pushed
the
sandroscosta/a11y/fix-organization-glipmse
branch
3 times, most recently
from
511a06d
to
45c1814
Compare
|
@jbpenrath apparently something went wrong with the CI, probably due to the rebase. |
sandroscosta
force-pushed
the
sandroscosta/a11y/fix-organization-glipmse
branch
from
45c1814
to
24681cf
Compare
There are 4 tests which are failing and they looks to be related to your changes. |
@jbpenrath I'm clearly not very smart. I just saw it. I'll get right on it. Sorry for wasting your time. |
sandroscosta
force-pushed
the
sandroscosta/a11y/fix-organization-glipmse
branch
from
24681cf
to
12054ba
Compare
- Add a small fix to the title property the organization glimpse - The value of title should be different from the organization card - Change the tests to fit the new rule
sandroscosta
force-pushed
the
sandroscosta/a11y/fix-organization-glipmse
branch
from
12054ba
to
c9f346d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
While validating our richie site, I came across an issue with the title on the organization glimpse cards. The link
titleproperty has the same value as the card span element. That might cause some repetition issues with screen readers. To avoid this, the title property should correctly enunciate that this is a link to the organization page. This way we get better context for our a11y users.Proposal