Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨(api) implement video new downloads endpoint #44

Merged
merged 7 commits into from
Jul 26, 2023
Merged

✨(api) implement video new downloads endpoint #44

merged 7 commits into from
Jul 26, 2023

Commits on Jul 26, 2023

  1. ⬆️(api) bump ralph-malp to v3.8 

    Upgrade ralph-malp to import a new xAPI verb.
Downloaded, from tincanapi is required to add the
new endpoint downloads.
    @lebaudantoine
    lebaudantoine committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    3ebac8f View commit details
    Browse the repository at this point in the history

  2. ✨(api) implement video new downloads endpoint 

    Enhance engagement metrics by implementing a new endpoint to track download
events on video resources. This endpoint queries an LRS for statements with
the 'Downloaded' xAPI verb (http://id.tincanapi.com/verb/downloaded).

The endpoint provides both a total count of events and a daily count for
studying download patterns.
    @lebaudantoine
    lebaudantoine committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    6495acd View commit details
    Browse the repository at this point in the history

  3. ♻️(api) avoid confusion while designating actor's identifier 

    To improve clarity and avoid confusion, we propose unifying the naming of
actor.uuid to use uid throughout the codebase. This change will provide a
consistent and clear representation, emphasizing that the identifier is unique,
though not necessarily universal.
    @lebaudantoine
    lebaudantoine committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    ebb272f View commit details
    Browse the repository at this point in the history

  4. ♻️(api) merge video views and downloads pydantic models 

    Current specific classes were not adding significant value beyond the
proposed base DailyCount and DailyCounts classes. They served as
aliases with different names, which led to redundant code.
    @lebaudantoine
    lebaudantoine committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    ddcca66 View commit details
    Browse the repository at this point in the history

  5. 🩹(api) fix mis-renamed endpoint parameter in tests 

    video_id was renamed to video_uuid whithout thorough attention.
Align all existing API tests.
    @lebaudantoine
    lebaudantoine committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    a61c44b View commit details
    Browse the repository at this point in the history

  6. ♻️(api) update timestamps fixtures to Ralph's format 

    After sutdying some raw statements from ralph, I noticed
that statements' timestamps were stored as date and time
string with an offset from UTC, and not as UTC.
    @lebaudantoine
    lebaudantoine committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    4da99ed View commit details
    Browse the repository at this point in the history

  7. ✅(api) add tests on video new downloads endpoint 

    Current tests are following the exact same structure as
the `views` ones. Please note that these tests are a basis
and should be extended with more advanced one as soon as the
API complexity and usage increase.
    @lebaudantoine
    lebaudantoine committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    97e6e57 View commit details
    Browse the repository at this point in the history