-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Call GrFormat only if file is actually binary
- Loading branch information
Showing
1 changed file
with
6 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4893e61
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A la ligne 208, tu as oublié d'utiliser l'info provenant de model/formatter_name
4893e61
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Il y a un problème. Si on utilise l'outil générique "importation" et non l'"importation single file", avant de convertir le fichier binaire, je ne peux pas savoir à quel comptage il se rapporte et donc je ne peux pas connaître le modèle utilisé.
Une possibilité serait de lire l'en-tête du fichier binaire qui contient quelque chose comme
Golden River Traffic Ltd\r\nMarksman 660 compatible data file
, mais pas le modèle exact et donc avec la tablemodel
actuelle on ne peut pas faire une query exacte.4893e61
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, je comprend. On peut alors mettre l'info dans la table brand, car c'est identique pour tous nos modèles