Early return if no valid relation available

opengisch · Oct 7, 2024 · 8b0a8b6 · 8b0a8b6
1 parent 5a0526d
commit 8b0a8b6
Showing 1 changed file with 8 additions and 7 deletions.
diff --git a/linking_relation_editor/gui/linking_relation_editor_widget.py b/linking_relation_editor/gui/linking_relation_editor_widget.py
@@ -774,19 +774,20 @@ def zoomToSelectedFeatures(self):
     def afterSetRelations(self):
         self._nmRelation = QgsProject.instance().relationManager().relation(str(self.nmRelationId()))
 
-        if self.relation().isValid():
-            self._checkTransactionGroup()
+        if not self.relation().isValid():
+            QgsLogger.warning(self.tr(f"Invalid relation set, relation id: '{self.relation().id()}'"))
+            self.updateButtons()
+            return
 
-            self.relation().referencingLayer().editingStopped.connect(self.updateButtons)
-            self.relation().referencingLayer().editingStarted.connect(self.updateButtons)
+        self._checkTransactionGroup()
+
+        self.relation().referencingLayer().editingStopped.connect(self.updateButtons)
+        self.relation().referencingLayer().editingStarted.connect(self.updateButtons)
 
         if self.nmRelation().isValid():
             self.nmRelation().referencedLayer().editingStarted.connect(self.updateButtons)
             self.nmRelation().referencedLayer().editingStopped.connect(self.updateButtons)
 
-        if not self.relation().isValid() and not self.nmRelation().isValid():
-            QgsLogger.warning(self.tr(f"No valid relation set. Relation id: '{self.relation().id()}' NM relation id: '{self.nmRelationId()}'"))
-
         self.updateButtons()
 
     def _checkTransactionGroup(self):