Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter Expression from Settings #49

Merged
merged 3 commits into from
Aug 21, 2024
Merged

Filter Expression from Settings #49

merged 3 commits into from
Aug 21, 2024

Conversation

signedav
Copy link
Member

@signedav signedav commented Jul 4, 2024

Kind of "default" filter expression from the settings.

Screencast.from.21.08.2024.10.54.12.webm

According to qgis/QGIS#58448

It does not need a QGIS version check. It's just empty when not available because QGIS version < 3.40 🤷

@signedav signedav changed the title prototyping for mockups for default filter Filter Expression from Settings Aug 21, 2024
@signedav signedav marked this pull request as ready for review August 21, 2024 08:57
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of the icon change? it's still SVG but with a default size?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not relevant for this implementation. it was just supertiny with a huge margin and now it's bigger.

@signedav signedav merged commit 60dc8fc into master Aug 21, 2024
2 checks passed
@signedav signedav deleted the filter branch August 21, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants