[lgthinq] Initial contribution #12149

nemerdaud · 2022-01-28T22:37:34Z

Binding to integrate OpenHab to LG Thinq API to control Thinq compatible devices through OpenHab.
See README.MD documentation for supported devices.

Signed-off-by: Nemer Daud [email protected]

openhab-bot · 2022-01-28T22:38:00Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/contribution-lg-thinq-air-conditioner-addon/132444/3

hmerk

Thanks for your contribution.
Please check for a constant naming scheme.
Some first comments made with required changes.

...inding.lgthinq/src/main/java/org/openhab/binding/lgthinq/internal/LGThinqHandlerFactory.java

....openhab.binding.lgthinq/src/main/java/org/openhab/binding/lgthinq/internal/api/Gateway.java

.../src/main/java/org/openhab/binding/lgthinq/internal/LGDeviceDynStateDescriptionProvider.java

...inding.lgthinq/src/main/java/org/openhab/binding/lgthinq/lgapi/LGApiV1ClientServiceImpl.java

...inding.lgthinq/src/main/java/org/openhab/binding/lgthinq/lgapi/LGApiV2ClientServiceImpl.java

....openhab.binding.lgthinq/src/main/java/org/openhab/binding/lgthinq/lgapi/model/LGDevice.java

bundles/org.openhab.binding.lgthinq/src/main/resources/OH-INF/i18n/lgthinq.properties

...openhab.binding.lgthinq/src/test/java/org/openhab/binding/lgthinq/handler/LGBridgeTests.java

...nq/src/main/java/org/openhab/binding/lgthinq/internal/discovery/LGThinqDiscoveryService.java

...inding.lgthinq/src/main/java/org/openhab/binding/lgthinq/internal/LGThinqHandlerFactory.java

...lgthinq/src/main/java/org/openhab/binding/lgthinq/internal/LGThinqAirConditionerHandler.java

...ding.lgthinq/src/main/java/org/openhab/binding/lgthinq/internal/LGThinqBindingConstants.java

...nq/src/main/java/org/openhab/binding/lgthinq/internal/discovery/LGThinqDiscoveryService.java

...binding.lgthinq/src/main/java/org/openhab/binding/lgthinq/lgapi/LGThinqApiClientService.java

...penhab.binding.lgthinq/src/main/java/org/openhab/binding/lgthinq/lgapi/model/ACSnapShot.java

...nhab.binding.lgthinq/src/main/java/org/openhab/binding/lgthinq/lgapi/model/ACSnapShotV1.java

....openhab.binding.lgthinq/src/main/java/org/openhab/binding/lgthinq/lgapi/model/LGDevice.java

...org.openhab.binding.lgthinq/src/test/java/org/openhab/binding/lgthinq/handler/JsonUtils.java

...ab.binding.lgthinq/src/test/java/org/openhab/binding/lgthinq/handler/LGThinqBridgeTests.java

...ding.lgthinq/src/main/java/org/openhab/binding/lgthinq/internal/LGThinqBindingConstants.java

tobof · 2022-02-03T20:47:53Z

@nemerdaud Gave your binding a first shot and it just worked. Amazing! 😄

tobof · 2022-02-05T13:24:56Z

Changing the op_mode does not seem to work, it results in an error after a few seconds.

14:19:13.543 [INFO ] [openhab.event.ItemStateChangedEvent  ] - Item 'corridorACMode' changed from 3 to 2
14:19:16.040 [ERROR] [ervices.LGThinqApiV2ClientServiceImpl] - Error returned by LG Server API. The reason is:{"resultCode":"9006","result":{"data":""}}
14:19:16.041 [ERROR] [internal.LGThinqAirConditionerHandler] - Error executing Command 3 to the channel op_mode. Thing goes offline until retry
org.openhab.binding.lgthinq.internal.errors.LGThinqApiException: Error returned by LG Server API. The reason is:{"resultCode":"9006","result":{"data":""}}
        at org.openhab.binding.lgthinq.lgservices.LGThinqApiV2ClientServiceImpl.handleV2GenericErrorResult(LGThinqApiV2ClientServiceImpl.java:231) ~[bundleFile:?]
        at org.openhab.binding.lgthinq.lgservices.LGThinqApiV2ClientServiceImpl.changeOperationMode(LGThinqApiV2ClientServiceImpl.java:128) ~[bundleFile:?]
        at org.openhab.binding.lgthinq.internal.LGThinqAirConditionerHandler$1.run(LGThinqAirConditionerHandler.java:443) [bundleFile:?]
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) [?:?]
        at java.util.concurrent.FutureTask.run(FutureTask.java:264) [?:?]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [?:?]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [?:?]
        at java.lang.Thread.run(Thread.java:829) [?:?]
14:19:16.043 [INFO ] [hab.event.ThingStatusInfoChangedEvent] - Thing 'lgthinq:401:2a9a539f15:569c7573-8e85-12aa-86e5-44cb8b809993' changed from ONLINE to OFFLINE (COMMUNICATION_ERROR): Error returned by LG Server API. The reason is:{"resultCode":"9006","result":{"data":""}}

nemerdaud · 2022-02-07T19:27:01Z

@tobof , please provide me $OPENHAB_USERDATA/thinq/thinq-569c7573-8e85-12aa-86e5-44cb8b809993-cap.json file.

Changing the op_mode does not seem to work, it results in an error after a few seconds.

14:19:13.543 [INFO ] [openhab.event.ItemStateChangedEvent  ] - Item 'corridorACMode' changed from 3 to 2
14:19:16.040 [ERROR] [ervices.LGThinqApiV2ClientServiceImpl] - Error returned by LG Server API. The reason is:{"resultCode":"9006","result":{"data":""}}
14:19:16.041 [ERROR] [internal.LGThinqAirConditionerHandler] - Error executing Command 3 to the channel op_mode. Thing goes offline until retry
org.openhab.binding.lgthinq.internal.errors.LGThinqApiException: Error returned by LG Server API. The reason is:{"resultCode":"9006","result":{"data":""}}
        at org.openhab.binding.lgthinq.lgservices.LGThinqApiV2ClientServiceImpl.handleV2GenericErrorResult(LGThinqApiV2ClientServiceImpl.java:231) ~[bundleFile:?]
        at org.openhab.binding.lgthinq.lgservices.LGThinqApiV2ClientServiceImpl.changeOperationMode(LGThinqApiV2ClientServiceImpl.java:128) ~[bundleFile:?]
        at org.openhab.binding.lgthinq.internal.LGThinqAirConditionerHandler$1.run(LGThinqAirConditionerHandler.java:443) [bundleFile:?]
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) [?:?]
        at java.util.concurrent.FutureTask.run(FutureTask.java:264) [?:?]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [?:?]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [?:?]
        at java.lang.Thread.run(Thread.java:829) [?:?]
14:19:16.043 [INFO ] [hab.event.ThingStatusInfoChangedEvent] - Thing 'lgthinq:401:2a9a539f15:569c7573-8e85-12aa-86e5-44cb8b809993' changed from ONLINE to OFFLINE (COMMUNICATION_ERROR): Error returned by LG Server API. The reason is:{"resultCode":"9006","result":{"data":""}}

…ature/lgthinq-binding

Signed-off-by: nemerdaud <[email protected]>

openhab-bot · 2024-08-24T13:00:37Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/snapshot-binding-will-not-load/157873/10

Signed-off-by: nemerdaud <[email protected]>

nemerdaud · 2024-08-29T14:12:56Z

@lsiepel , I think I resolved all the itens. Fell free to continue the review.

lsiepel

This pass i had a better look to some dto / model / and other code files. Some comments can be applied binding wide, please check.
Also want to mention that there are 100+ compile warnings. Most of them should be fixed, the same for the SAT warnings.

bundles/org.openhab.binding.lgthinq/src/main/feature/feature.xml

...b.binding.lgthinq/src/main/java/org/openhab/binding/lgthinq/internal/api/LGThinqGateway.java

....lgthinq/src/main/java/org/openhab/binding/lgthinq/internal/api/OauthLgEmpAuthenticator.java

...penhab.binding.lgthinq/src/main/java/org/openhab/binding/lgthinq/internal/api/RestUtils.java

...ing.lgthinq/src/main/java/org/openhab/binding/lgthinq/internal/type/ThingModelTypeUtils.java

...org.openhab.binding.lgthinq/src/test/java/org/openhab/binding/lgthinq/handler/JsonUtils.java

...penhab.binding.lgthinq/src/main/java/org/openhab/binding/lgthinq/internal/api/RestUtils.java

...rc/test/java/org/openhab/binding/lgthinq/internal/handler/LGThinQWasherDryerHandlerTest.java

...nq/src/main/java/org/openhab/binding/lgthinq/lgservices/LGThinQWMApiV2ClientServiceImpl.java

marcelrv · 2024-10-31T15:14:43Z

@nemerdaud sorry for my commit e473608 directly to your branch. Intended to make it in a private branch but clearly that did not happen.

Signed-off-by: Nemer Daud <[email protected]>

nemerdaud · 2024-11-04T02:43:28Z

Sorry for the delay, @lsiepel . It was a little bit of work to fix the warning (compiler & sat) and logs. The last review is done (I hope :-) ) .

lsiepel

Thank you for maintaining this PR and working towards a merge. In general the binding is in a good shape. The review is mainly about smaller issues like naming, labels and smaller inconsistency's but the overall structure seems good.
When looking at the comments, please keep in mind that the sugggestions might also apply to other places. Especially when looking at null suppresions and thing/channel structure.
Looked at 148/154 files, only the handlers are left.

bundles/org.openhab.binding.lgthinq/README.md

lsiepel · 2024-11-05T15:07:47Z

bundles/org.openhab.binding.lgthinq/README.md

+The ThinQ Bridge is necessary to work as a hub/bridge to discovery and first configure the LG ThinQ devices related with the LG's user account.
+Then, the first thing is to create the LG ThinQ Bridge and then, it will discover all Things you have related in your LG Account.


These two lines should be moved to the discovery paragraph (and streamlined)

I think the second paragraph is unnecessary since it's a basic concept of the platform.

To make sure we talk about the same, to what lines do you refer with the second paragraph?

There were some redundant and unnecessary information. I reorganized this 2 topics like this:
`

Bridge Thing

This Binding has a Bridge responsible for discovering and registering LG Things.
Thus, adding the Bridge (LGThinq GW Bridge) is the first step in configuring this Binding.

Discovery

This Binding has auto-discovery for the supported LG Thinq devices. Once LG Thinq Bridge has been added, LG Thinq devices linked to your account will be automatically discovered and displayed in the OpenHab Inbox.
`
Let me know if it's OK for you.

bundles/org.openhab.binding.lgthinq/README.md

...a/org/openhab/binding/lgthinq/lgservices/model/devices/fridge/FridgeCapabilityFactoryV1.java

lsiepel · 2024-11-05T19:49:57Z

....lgthinq/src/main/java/org/openhab/binding/lgthinq/lgservices/LGThinQACApiClientService.java

+ */
+@NonNullByDefault
+public interface LGThinQACApiClientService extends LGThinQApiClientService<ACCapability, ACCanonicalSnapshot> {
+    void changeOperationMode(String bridgeName, String deviceId, int newOpMode) throws LGThinqApiException;


See earlier comment, please provide javadoc to all public interfaces methods

Sorry, I missed it ! It will take some time...

...hinq/src/main/java/org/openhab/binding/lgthinq/lgservices/api/LGThinqCanonicalModelUtil.java

...binding.lgthinq/src/main/java/org/openhab/binding/lgthinq/lgservices/api/LGThinqGateway.java

...q/src/main/java/org/openhab/binding/lgthinq/lgservices/api/LGThinqOauthEmpAuthenticator.java

lsiepel · 2024-11-06T10:25:52Z

Regarding the review, I would propose that you comment or thumbs up a comment if it has been fixed. I can then verify and mark it resolved. This would make it easy for me to keep track. Hope it also works for you.

Signed-off-by: Nemer Daud <[email protected]>

nemerdaud · 2024-11-06T15:20:31Z

Regarding the review, I would propose that you comment or thumbs up a comment if it has been fixed. I can then verify and mark it resolved. This would make it easy for me to keep track. Hope it also works for you.

OK ! I think it's better. When I fix an item, I will push it and thumbs up in a sequence.

lsiepel · 2024-12-02T20:51:14Z

Where do we stand with this PR? Do you think we can manage to get this finished in a week? (due to code feature freeze before 4.3.0)

wborn · 2024-12-15T20:54:23Z

bundles/org.openhab.binding.lgthinq/pom.xml

+  <parent>
+    <groupId>org.openhab.addons.bundles</groupId>
+    <artifactId>org.openhab.addons.reactor.bundles</artifactId>
+    <version>4.3.0-SNAPSHOT</version>


Suggested change

<version>4.3.0-SNAPSHOT</version>

<version>5.0.0-SNAPSHOT</version>

nemerdaud · 2024-12-16T12:30:10Z

Sorry, @lsiepel, for the long silence. I was very busy at work and couldn't give much attention to this PR :-(. I have more time now, I'll focus on finishing these reviews!

[lgthinq][fix] Refrigerator channel command handle fixes Signed-off-by: Nemer Daud <[email protected]>

nemerdaud requested a review from a team as a code owner January 28, 2022 22:37

lolodomo added the new binding If someone has started to work on a binding. For a new binding PR. label Jan 29, 2022

hmerk requested changes Jan 29, 2022

View reviewed changes

...nq/src/main/java/org/openhab/binding/lgthinq/internal/discovery/LGThinqDiscoveryService.java Outdated Show resolved Hide resolved

nemerdaud requested a review from hmerk January 29, 2022 18:34

hmerk requested changes Jan 30, 2022

View reviewed changes

...ding.lgthinq/src/main/java/org/openhab/binding/lgthinq/internal/LGThinqBindingConstants.java Outdated Show resolved Hide resolved

nemerdaud force-pushed the feature/lgthinq-binding branch 2 times, most recently from aea5f82 to ef8745b Compare February 8, 2022 20:43

hmerk changed the title ~~[lgthinq] New LG Thinq Binding~~ [lgthinq] [WIP] New LG Thinq Binding Feb 12, 2022

hmerk added the work in progress A PR that is not yet ready to be merged label Feb 12, 2022

nemerdaud force-pushed the feature/lgthinq-binding branch from 356b6b6 to 5a1eb61 Compare May 4, 2022 11:52

nemerdaud requested review from cweitkamp, kaikreuzer, svilenvul, marcelrv, wborn, ssalonen, BjoernLange, GiviMAD, JochenHiller, lolodomo, jochen314, davidgraeff, digitaldan and andylintner as code owners June 29, 2022 00:39

nemerdaud added 3 commits August 23, 2024 19:28

Merge remote-tracking branch 'origin/feature/lgthinq-binding' into fe…

c2a621c

…ature/lgthinq-binding

[lgthinq][fix] Code Format violations

c2a9b9a

Signed-off-by: nemerdaud <[email protected]>

[lgthinq][fix] Documentation

58e95e4

Signed-off-by: nemerdaud <[email protected]>

nemerdaud added 3 commits August 26, 2024 08:40

[lgthinq][fix] configurations pattern review

ec821bc

Signed-off-by: nemerdaud <[email protected]>

[lgthinq][fix] documentation

cd6382d

Signed-off-by: nemerdaud <[email protected]>

[lgthinq][fix] documentation and name convention

305ebfa

Signed-off-by: nemerdaud <[email protected]>

lsiepel requested changes Sep 9, 2024

View reviewed changes

nemerdaud force-pushed the feature/lgthinq-binding branch from 4a20df9 to 305ebfa Compare November 4, 2024 00:43

Nemer Daud added 4 commits November 3, 2024 21:48

[lgthinq][fix] fix code to remove warnings in complication

e7d68d1

Signed-off-by: Nemer Daud <[email protected]>

[lgthinq][fix] fix code to remove warnings in complication

dace432

Signed-off-by: Nemer Daud <[email protected]>

[lgthinq][fix] fix code revision list

032ae44

Signed-off-by: Nemer Daud <[email protected]>

[lgthinq][fix] fix log

7eac499

Signed-off-by: Nemer Daud <[email protected]>

lsiepel requested changes Nov 5, 2024

View reviewed changes

Nemer Daud added 7 commits November 6, 2024 11:34

[lgthinq][fix] review fixes

8ff725d

Signed-off-by: Nemer Daud <[email protected]>

[lgthinq][fix] review fixes

d92f957

Signed-off-by: Nemer Daud <[email protected]>

[lgthinq][fix] review fixes

0ed7ca5

Signed-off-by: Nemer Daud <[email protected]>

[lgthinq][fix] review fixes

c23e6f0

Signed-off-by: Nemer Daud <[email protected]>

[lgthinq][fix] review fixes

261f00e

Signed-off-by: Nemer Daud <[email protected]>

[lgthinq][fix] review fixes

600d83e

Signed-off-by: Nemer Daud <[email protected]>

[lgthinq][fix] review fixes

1b57051

Signed-off-by: Nemer Daud <[email protected]>

wborn reviewed Dec 15, 2024

View reviewed changes

[lgthinq][fix] review fixes

375aef6

[lgthinq][fix] Refrigerator channel command handle fixes Signed-off-by: Nemer Daud <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[lgthinq] Initial contribution #12149

[lgthinq] Initial contribution #12149

nemerdaud commented Jan 28, 2022 •

edited

Loading

openhab-bot commented Jan 28, 2022

hmerk left a comment

tobof commented Feb 3, 2022

tobof commented Feb 5, 2022

nemerdaud commented Feb 7, 2022

openhab-bot commented Aug 24, 2024

nemerdaud commented Aug 29, 2024

lsiepel left a comment

marcelrv commented Oct 31, 2024

nemerdaud commented Nov 4, 2024

lsiepel left a comment •

edited

Loading

lsiepel Nov 5, 2024

nemerdaud Nov 6, 2024

lsiepel Nov 6, 2024

nemerdaud Nov 6, 2024 •

edited

Loading

lsiepel Nov 5, 2024

nemerdaud Nov 6, 2024

lsiepel commented Nov 6, 2024

nemerdaud commented Nov 6, 2024

lsiepel commented Dec 2, 2024

wborn Dec 15, 2024

nemerdaud commented Dec 16, 2024

		The ThinQ Bridge is necessary to work as a hub/bridge to discovery and first configure the LG ThinQ devices related with the LG's user account.
		Then, the first thing is to create the LG ThinQ Bridge and then, it will discover all Things you have related in your LG Account.

	<version>4.3.0-SNAPSHOT</version>
	<version>5.0.0-SNAPSHOT</version>

[lgthinq] Initial contribution #12149

Are you sure you want to change the base?

[lgthinq] Initial contribution #12149

Conversation

nemerdaud commented Jan 28, 2022 • edited Loading

openhab-bot commented Jan 28, 2022

hmerk left a comment

Choose a reason for hiding this comment

tobof commented Feb 3, 2022

tobof commented Feb 5, 2022

nemerdaud commented Feb 7, 2022

openhab-bot commented Aug 24, 2024

nemerdaud commented Aug 29, 2024

lsiepel left a comment

Choose a reason for hiding this comment

marcelrv commented Oct 31, 2024

nemerdaud commented Nov 4, 2024

lsiepel left a comment • edited Loading

Choose a reason for hiding this comment

lsiepel Nov 5, 2024

Choose a reason for hiding this comment

nemerdaud Nov 6, 2024

Choose a reason for hiding this comment

lsiepel Nov 6, 2024

Choose a reason for hiding this comment

nemerdaud Nov 6, 2024 • edited Loading

Choose a reason for hiding this comment

Bridge Thing

Discovery

lsiepel Nov 5, 2024

Choose a reason for hiding this comment

nemerdaud Nov 6, 2024

Choose a reason for hiding this comment

lsiepel commented Nov 6, 2024

nemerdaud commented Nov 6, 2024

lsiepel commented Dec 2, 2024

wborn Dec 15, 2024

Choose a reason for hiding this comment

nemerdaud commented Dec 16, 2024

nemerdaud commented Jan 28, 2022 •

edited

Loading

lsiepel left a comment •

edited

Loading

nemerdaud Nov 6, 2024 •

edited

Loading