Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Netatmo] Binding rewrite without external dependencies #12357

Merged
merged 67 commits into from
May 6, 2022
Merged

[Netatmo] Binding rewrite without external dependencies #12357

merged 67 commits into from
May 6, 2022

Commits on Apr 5, 2022

  1. Switching to SNAPSHOT 3.3 

    Updated file headers
Removing deprecated Netatmo API

Signed-off-by: clinique <[email protected]>
    @clinique
    clinique committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    6577ebf View commit details
    Browse the repository at this point in the history

  2. Correcting schedule handling of energy home 

    Correcting setpoint handling for rooms

Signed-off-by: clinique <[email protected]>
    @clinique
    clinique committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    fe7502e View commit details
    Browse the repository at this point in the history

  3. Protect maximum temperature setting 

    Signed-off-by: clinique <[email protected]>
    @clinique
    clinique committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    982e2f9 View commit details
    Browse the repository at this point in the history

  4. Capabilities enhancement and @jlaur code review integration. 

    Signed-off-by: clinique <[email protected]>
    @clinique
    clinique committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    a62544b View commit details
    Browse the repository at this point in the history

  5. Simplified the handler architecture. 

    Introduced variable capabilities.
Not all things are bridge anymore.
I think I've completely cleaned up the base of the binding. Some testings needed now.

Signed-off-by: clinique <[email protected]>
    @clinique
    clinique committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    a85d155 View commit details
    Browse the repository at this point in the history

  6. Removing ApiBridge 

    Signed-off-by: clinique <[email protected]>
    @clinique
    clinique committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    7262f22 View commit details
    Browse the repository at this point in the history

  7. Finalization of the inclusion of a Netatmo API bridge. 

    Signed-off-by: clinique <[email protected]>
    @clinique
    clinique committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    8ceec0a View commit details
    Browse the repository at this point in the history

  8. Solving problem on token refresh 

    Signed-off-by: clinique <[email protected]>
    @clinique
    clinique committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    30bc6d0 View commit details
    Browse the repository at this point in the history

  9. Correcting documentation of thing configuration example 

    Signed-off-by: clinique <[email protected]>
    @clinique
    clinique committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    4313989 View commit details
    Browse the repository at this point in the history

  10. Renamed NABridge to NAAccount 

    Signed-off-by: clinique <[email protected]>
    @clinique
    clinique committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    6fdf093 View commit details
    Browse the repository at this point in the history

  11. Changing things name. Decoupled from Netatmo API description of modul… 

    …es and devices

Signed-off-by: clinique <[email protected]>
    @clinique
    clinique committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    7643f06 View commit details
    Browse the repository at this point in the history

  12. Doc error, some files remained unstaged. 

    Signed-off-by: clinique <[email protected]>
    @clinique
    clinique committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    1082a1d View commit details
    Browse the repository at this point in the history

  13. Adressing all open comments 

    Signed-off-by: clinique <[email protected]>
    @clinique
    clinique committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    6a06da7 View commit details
    Browse the repository at this point in the history

  14. Unstaging missing files 

    Signed-off-by: clinique <[email protected]>
    @clinique
    clinique committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    1f51af0 View commit details
    Browse the repository at this point in the history

  15. Adressing jlaur fine comments 

    Signed-off-by: clinique <[email protected]>
    @clinique
    clinique committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    f595a0e View commit details
    Browse the repository at this point in the history

  16. Generating default netatmo.properties files to get ready for crowdin 

    Signed-off-by: clinique <[email protected]>
    @clinique
    clinique committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    ea73521 View commit details
    Browse the repository at this point in the history

  17. Correcting an issue in auto-discovery generated by thing type names c… 

    …hange of previous commit.

Added Siren module type.

Signed-off-by: clinique <[email protected]>
    @clinique
    clinique committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    4c2c942 View commit details
    Browse the repository at this point in the history

  18. Dynamic channels enhancements 

    Signed-off-by: clinique <[email protected]>
    @clinique
    clinique committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    835ea74 View commit details
    Browse the repository at this point in the history

  19. Adressing issue with Person events 

    Signed-off-by: clinique <[email protected]>
    @clinique
    clinique committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    089a2ef View commit details
    Browse the repository at this point in the history

  20. Address reconnection issue 

    Signed-off-by: clinique <[email protected]>
    @clinique
    clinique committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    3d2d39a View commit details
    Browse the repository at this point in the history

  21. Switching to SNAPSHOT 3.3 

    Updated file headers
Removing deprecated Netatmo API

Signed-off-by: clinique <[email protected]>
    @clinique
    clinique committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    2acf49f View commit details
    Browse the repository at this point in the history

  22. Solving conflicts. 

    Adding system.indoor-temperature and system.outdoor-temperature.

Signed-off-by: clinique <[email protected]>
    @clinique
    clinique committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    6380db1 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2022

  1. Correcting outside temperature channel group type. 

    Signed-off-by: clinique <[email protected]>
    @clinique
    clinique committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    fbc2250 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2022

  1. Addressing @jlaur review comments 

    Signed-off-by: clinique <[email protected]>
    @clinique
    clinique committed Apr 17, 2022
    Configuration menu
    Copy the full SHA
    1f454ba View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2022

  1. Adding list of available modules in the README.MD 

    Removed last reference to ZonedDataTime in RefreshCapability.

Signed-off-by: clinique <[email protected]>
    @clinique
    clinique committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    0506630 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2022

  1. Imrpoved channel types and README 

    Signed-off-by: Laurent Garnier <[email protected]>
    @lolodomo
    lolodomo committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    b32b62c View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2022

  1. Merge pull request #11 from lolodomo/fix_channeltypes_README 

    Imrpoved channel types and README
    @clinique
    clinique authored Apr 26, 2022
    Configuration menu
    Copy the full SHA
    d6a2809 View commit details
    Browse the repository at this point in the history

  2. @lolodomo review. Adressed redundant channel config, various README o… 

    …bservation by @jlaur

Signed-off-by: clinique <[email protected]>
    @clinique
    clinique committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    1a21aae View commit details
    Browse the repository at this point in the history

  3. Adressing disconnection issue + some left overs 

    Signed-off-by: clinique <[email protected]>
    @clinique
    clinique committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    dc6fae4 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2022

  1. Fix NetatmoException to keep the error message 

    Signed-off-by: Laurent Garnier <[email protected]>
    @lolodomo
    lolodomo committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    39da6a5 View commit details
    Browse the repository at this point in the history

  2. README: list thing parameters 

    Signed-off-by: Laurent Garnier <[email protected]>
    @lolodomo
    lolodomo committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    15858f7 View commit details
    Browse the repository at this point in the history

  3. Improved set of the HTTP request content type 

    Signed-off-by: Laurent Garnier <[email protected]>
    @lolodomo
    lolodomo committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    96dde79 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2022

  1. Merge pull request #12 from lolodomo/fix_NetatmoException 

    Fix NetatmoException to keep the error message
    @clinique
    clinique authored Apr 28, 2022
    Configuration menu
    Copy the full SHA
    97bac08 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #13 from lolodomo/doc_thing_parameters 

    README: list thing parameters
    @clinique
    clinique authored Apr 28, 2022
    Configuration menu
    Copy the full SHA
    39da3d2 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #14 from lolodomo/request_content_type 

    Improved set of the HTTP request content type
    @clinique
    clinique authored Apr 28, 2022
    Configuration menu
    Copy the full SHA
    3681f45 View commit details
    Browse the repository at this point in the history

  4. Integrating @jlaur observations 

    Signed-off-by: clinique <[email protected]>
    @clinique
    clinique committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    09c0b92 View commit details
    Browse the repository at this point in the history

  5. Adressing some forgot observations 

    Signed-off-by: clinique <[email protected]>
    @clinique
    clinique committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    2703b64 View commit details
    Browse the repository at this point in the history

  6. Fix bridge/things status handling 

    Signed-off-by: Laurent Garnier <[email protected]>
    @lolodomo
    lolodomo committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    36c277c View commit details
    Browse the repository at this point in the history

  7. Merge pull request #15 from lolodomo/bridgethinghandling 

    Fix bridge/things status handling
    @clinique
    clinique authored Apr 28, 2022
    Configuration menu
    Copy the full SHA
    0c48f12 View commit details
    Browse the repository at this point in the history

  8. Merging @lolodomo PR n° 15 + requested corrections. 

    Signed-off-by: clinique <[email protected]>
    @clinique
    clinique committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    695829e View commit details
    Browse the repository at this point in the history

  9. Forgot to apply spotless 

    Signed-off-by: clinique <[email protected]>
    @clinique
    clinique committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    eea483d View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2022

  1. Code corrections 

    Signed-off-by: clinique <[email protected]>
    @clinique
    clinique committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    2d48d8e View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2022

  1. Adressing @jlaur minor comments 

    Signed-off-by: clinique <[email protected]>
    @clinique
    clinique committed Apr 30, 2022
    Configuration menu
    Copy the full SHA
    ffd041c View commit details
    Browse the repository at this point in the history

  2. Several fixes related to the management of home events 

    New event types: HUMAN, ANIMAL, PERSON_HOME

Channel video-status set to NULL if no video attached to the event

Channel video-url set when a video is atteched to the event

Events sorted to get the most recent one

Avoid redundant calls to HTTP requests getevents for camero and person

Signed-off-by: Laurent Garnier <[email protected]>
    @lolodomo
    lolodomo committed Apr 30, 2022
    Configuration menu
    Copy the full SHA
    4d8eab2 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #16 from lolodomo/homeevent 

    Several fixes related to the management of home events
    @clinique
    clinique authored Apr 30, 2022
    Configuration menu
    Copy the full SHA
    1cd5121 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2022

  1. Default translations and various minor corrections 

    Signed-off-by: clinique <[email protected]>
    @clinique
    clinique committed May 1, 2022
    Configuration menu
    Copy the full SHA
    8b7ec37 View commit details
    Browse the repository at this point in the history

  2. Correction of last-event#video-url 

    Signed-off-by: clinique <[email protected]>
    @clinique
    clinique committed May 1, 2022
    Configuration menu
    Copy the full SHA
    e60b3cd View commit details
    Browse the repository at this point in the history

Commits on May 2, 2022

  1. Added capability for camera to detect offline status. 

    Removed ONLINE/OFFLINE handling from Capabilities, moved to handler.
Removed implicit addition of MeasureCapability and ChannelHelper from factory to enforce explicit definition in ModuleType.
Code review corrections

Signed-off-by: clinique <[email protected]>
    @clinique
    clinique committed May 2, 2022
    Configuration menu
    Copy the full SHA
    5863602 View commit details
    Browse the repository at this point in the history

  2. Reintroduced refreshPeriod for Cameras (at HOME level as Home holds t… 

    …he RefreshCapability).

Added data freshness control for weather station modules.

Signed-off-by: clinique <[email protected]>
    @clinique
    clinique committed May 2, 2022
    Configuration menu
    Copy the full SHA
    d2f3ded View commit details
    Browse the repository at this point in the history

  3. Taking in account configured refreshInterval. 

    Changed refresh interval to seconds.
Limited data freshness control to physical modules types.

Signed-off-by: clinique <[email protected]>
    @clinique
    clinique committed May 2, 2022
    Configuration menu
    Copy the full SHA
    c872003 View commit details
    Browse the repository at this point in the history

  4. Adding channels to handle vpn url of video feeds. 

    Signed-off-by: clinique <[email protected]>
    @clinique
    clinique committed May 2, 2022
    Configuration menu
    Copy the full SHA
    c3c4d49 View commit details
    Browse the repository at this point in the history

  5. No live stream URL if camera monitoring is disabled 

    Signed-off-by: Laurent Garnier <[email protected]>
    @lolodomo
    lolodomo committed May 2, 2022
    Configuration menu
    Copy the full SHA
    b09322e View commit details
    Browse the repository at this point in the history

Commits on May 3, 2022

  1. Merge pull request #17 from lolodomo/live_stream_url 

    No live stream URL if camera monitoring is disabled
    @clinique
    clinique authored May 3, 2022
    Configuration menu
    Copy the full SHA
    722b0ca View commit details
    Browse the repository at this point in the history

  2. Adding local and vpn channels for snapshots 

    Code review corrections.

Signed-off-by: clinique <[email protected]>
    @clinique
    clinique committed May 3, 2022
    Configuration menu
    Copy the full SHA
    b95835f View commit details
    Browse the repository at this point in the history

  3. Ignore monitoring status when handling camera events 

    Do not rely on call to setUrls to get the camera monitoring status
as it is called too late

Signed-off-by: Laurent Garnier <[email protected]>
    @lolodomo
    lolodomo committed May 3, 2022
    Configuration menu
    Copy the full SHA
    002fef5 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #18 from lolodomo/ignore_monitoring_status 

    Ignore monitoring status when handling camera events
    @clinique
    clinique authored May 3, 2022
    Configuration menu
    Copy the full SHA
    3267852 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2022

  1. Addressing code review comments. 

    Handling issue with : double events reception and reception of events not targeted to the thing.
Seperated offline because inactive from offline because data over age limit.
Adressing child modules not coming back on-line

Signed-off-by: clinique <[email protected]>
    @clinique
    clinique committed May 4, 2022
    Configuration menu
    Copy the full SHA
    855123d View commit details
    Browse the repository at this point in the history

Commits on May 5, 2022

  1. Adressing last code review comments. 

    Signed-off-by: clinique <[email protected]>
    @clinique
    clinique committed May 5, 2022
    Configuration menu
    Copy the full SHA
    57e1dd1 View commit details
    Browse the repository at this point in the history

  2. Trying to address modules staying unknown until next cycle. 

    Signed-off-by: clinique <[email protected]>
    @clinique
    clinique committed May 5, 2022
    Configuration menu
    Copy the full SHA
    bf2dd45 View commit details
    Browse the repository at this point in the history

  3. Correcting bug messages. 

    Signed-off-by: clinique <[email protected]>
    @clinique
    clinique committed May 5, 2022
    Configuration menu
    Copy the full SHA
    ef7a0c5 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2022

  1. Changed data freshness timeout to 3600 s. 

    Removed data freshness control from modules, now only on Health Coach and Weather station
Renamed ModuleCapability (badly named) to DeviceCapability
Clarified point on the TODO in Person.java => no more used

Signed-off-by: clinique <[email protected]>
    @clinique
    clinique committed May 6, 2022
    Configuration menu
    Copy the full SHA
    f80b9fa View commit details
    Browse the repository at this point in the history

  2. Detect camera disconnection/reconnection 

    Signed-off-by: Laurent Garnier <[email protected]>
    @lolodomo
    lolodomo committed May 6, 2022
    Configuration menu
    Copy the full SHA
    383c720 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #19 from lolodomo/detect_disconnected_camera 

    Detect camera disconnection/reconnection
    @clinique
    clinique authored May 6, 2022
    Configuration menu
    Copy the full SHA
    74482ab View commit details
    Browse the repository at this point in the history

  4. Refresh strategy fixed when thing is OFFLINE 

    Signed-off-by: Laurent Garnier <[email protected]>
    @lolodomo
    lolodomo committed May 6, 2022
    Configuration menu
    Copy the full SHA
    f8e56df View commit details
    Browse the repository at this point in the history

  5. Merge pull request #20 from lolodomo/refresh_strategy_when_offline 

    Refresh strategy fixed when thing is OFFLINE
    @clinique
    clinique authored May 6, 2022
    Configuration menu
    Copy the full SHA
    ebccc88 View commit details
    Browse the repository at this point in the history

  6. Integrated last comments of @jlaur 

    Signed-off-by: clinique <[email protected]>
    @clinique
    clinique committed May 6, 2022
    Configuration menu
    Copy the full SHA
    23b1b7b View commit details
    Browse the repository at this point in the history

  7. Correction of pmd 

    Signed-off-by: clinique <[email protected]>
    @clinique
    clinique committed May 6, 2022
    Configuration menu
    Copy the full SHA
    45526e2 View commit details
    Browse the repository at this point in the history