-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fpp] Initial contribution #16298
[fpp] Initial contribution #16298
Conversation
c5cb6e0
to
01b6d86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is a WIP for some months, that is perfectly fine. There are some build failures and other issues. I did a quickscan and the most important one te mention is that the channel and type id's are not according to the naming convention (lower-case-hyphen
)
For reference: https://www.openhab.org/docs/developer/guidelines.html#naming-convention
Hope you can proceed with this PR, let me know if you need anything.
bundles/org.openhab.binding.mqtt.fpp/src/main/feature/feature.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Scott Hanson <[email protected]>
Signed-off-by: Scott Hanson <[email protected]>
Signed-off-by: Scott Hanson <[email protected]>
Signed-off-by: Scott Hanson <[email protected]>
Signed-off-by: Scott Hanson <[email protected]>
Signed-off-by: Scott Hanson <[email protected]>
Signed-off-by: Scott Hanson <[email protected]>
Signed-off-by: Scott Hanson <[email protected]>
9541a05
to
5785831
Compare
Signed-off-by: Scott Hanson <[email protected]>
Signed-off-by: Scott Hanson <[email protected]>
Co-authored-by: Wouter Born <[email protected]> Signed-off-by: Scott Hanson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this contribution. Basics of this binding already seem good, there are some comments and questions. Besides this:
- check compile warnings, there should be no warnings.
- check SAT, only the missing bridge with id broker is ok, the rest should be fixed.
Let me know if you need anything to proceed, ping me when you are ready for another review round.
...g.mqtt.fpp/src/main/java/org/openhab/binding/mqtt/fpp/internal/handler/FPPPlayerHandler.java
Outdated
Show resolved
Hide resolved
...g.mqtt.fpp/src/main/java/org/openhab/binding/mqtt/fpp/internal/handler/FPPPlayerHandler.java
Show resolved
Hide resolved
...g.mqtt.fpp/src/main/java/org/openhab/binding/mqtt/fpp/internal/handler/FPPPlayerHandler.java
Show resolved
Hide resolved
...g.mqtt.fpp/src/main/java/org/openhab/binding/mqtt/fpp/internal/handler/FPPPlayerHandler.java
Outdated
Show resolved
Hide resolved
Co-authored-by: lsiepel <[email protected]> Signed-off-by: Scott Hanson <[email protected]>
Co-authored-by: lsiepel <[email protected]> Signed-off-by: Scott Hanson <[email protected]>
Co-authored-by: lsiepel <[email protected]> Signed-off-by: Scott Hanson <[email protected]>
Signed-off-by: Scott Hanson <[email protected]>
Signed-off-by: Scott Hanson <[email protected]>
Signed-off-by: Scott Hanson <[email protected]>
There is one comment left open, besides that this binding should also be added to the footer.xml here and add yourself as codeowner here |
Signed-off-by: Scott Hanson <[email protected]>
Signed-off-by: Scott Hanson <[email protected]>
@computergeek1507 We can merge this and get it in the next milestone if you add the last two bits: codewoner and footer.xml |
Signed-off-by: Scott Hanson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM.
Now, you could add your binding's logo to the openHAB website. See https://next.openhab.org/docs/developer/addons/#add-your-add-on-s-logo-to-the-openhab-website-and-the-ui
Description
Created a binding to Controls Falcon Player (FPP) Devices. Uses MQTT to update status.
https://community.openhab.org/t/fpp-binding/157478