Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nikohomecontrol] Fix basic alarm #17360

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

mherwege
Copy link
Contributor

@mherwege mherwege commented Sep 2, 2024

#16834 introduced better support for alarm systems in Niko Home Control.

It broke the functionality when the alarm is not a full alarm system with arming/disarming functionality, but just an trigger. This fix restores basic functionality.

Signed-off-by: Mark Herwege <[email protected]>
@mherwege mherwege added the bug An unexpected problem or unintended behavior of an add-on label Sep 2, 2024
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit ffa59f8 into openhab:main Sep 3, 2024
5 checks passed
@lolodomo lolodomo added this to the 4.3 milestone Sep 3, 2024
@lsiepel lsiepel changed the title [nikohomecontrol] fix basic alarm [nikohomecontrol] Fix basic alarm Sep 3, 2024
@mherwege mherwege deleted the nikohomecontrol_alarm branch September 3, 2024 17:28
digitaldan pushed a commit to digitaldan/openhab-addons that referenced this pull request Sep 24, 2024
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Ciprian Pascu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants