-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enocean] D2-01-0C implement support for pilot wire mode #17450
base: main
Are you sure you want to change the base?
Conversation
Rename constants name from *RESPONE to *RESPONSE Signed-off-by: Zhivka Dimova <[email protected]>
Refs openhab#6938 Signed-off-by: Zhivka Dimova <[email protected]>
305c27c
to
1e9da72
Compare
Would you be able to frix the DCO? |
Signed-off-by: Zhivka Dimova <[email protected]>
f45a439
to
093a3b2
Compare
As this is touching the D2-01-0C device type, can you make its description in enocean.properties and MeasurementSwitch more unique from the other descriptions? (It appears twice in each file). The current description is “Switching and energy measurement (EEP: D2_01_0C)”. Looking at the table on page 132 of https://www.enocean-alliance.org/wp-content/uploads/2017/05/EnOcean_Equipment_Profiles_EEP_v2.6.7_public.pdf, you could add “power” (as some D2-01 devices have/do not have this element), and “pilot wire” (as only D2-01-0C) has it. The purpose of writing more precise text is to make it more distinguishable for users from the other device types. |
I have updated at #17522 the description for D2-01-0C and other devices. I kept there receivingEEPId and sendingEEPId are identical. I do not know if this is correct. |
You can ask in the OpenHAB Forum - https://community.openhab.org/ - if somebody can test this. |
Refs #6938
I haven't tested this code because I don't have such a device, so please wait until someone with such a device test it and confirm that everything works.
Test jar file here