Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tesla] Add null annotations #17582

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

[tesla] Add null annotations #17582

wants to merge 3 commits into from

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Oct 17, 2024

  • Fix null annotations
  • Fix compile warnings
  • Updated and moved DTO's to dto folder

Only form code perspective, needs some testing to be sure no regression occures.

Test jar 4.3.0 (should also work with 4.2.x) https://1drv.ms/u/s!AnMcxmvEeupwj4oOcmeYDamnLAcyAg?e=k2nzcw

@lsiepel
First pass
c2c4595 
Signed-off-by: Leo Siepel <[email protected]>
@lsiepel
Pass 2
1117ef6 
Signed-off-by: Leo Siepel <[email protected]>
@lsiepel
Final pass
e2e9154 
Signed-off-by: Leo Siepel <[email protected]>
@lsiepel lsiepel added enhancement An enhancement or new feature for an existing add-on additional testing preferred The change works for the pull request author. A test from someone else is preferred though. labels Oct 17, 2024
@lsiepel lsiepel mentioned this pull request Oct 17, 2024
Open
@lsiepel
Copy link
Contributor Author

lsiepel commented Oct 25, 2024

@kaikreuzer would you be able to test this binding? As you seem one of the few that not be forced to use the fleet api yet.

@kaikreuzer
Copy link
Member

Hey @lsiepel! Thanks for the clean-ups! I've installed this version on my production system and will watch it over the day tomorrow. So far, it seems to work and I do not see any issues in my logs. Will keep you posted.

@kaikreuzer
Copy link
Member

Unfortunately, I do not seem to receive any updates anymore - so I would say that this PR seems to break the functionality.
I'd need more time to deeply look into it in order to debug the issue...

@lsiepel
Copy link
Contributor Author

lsiepel commented Oct 28, 2024

ook into it in order to debug the issue...

Too bad, looking at the code again i can't spot the obvious error. If you can provide debug logs and your observations i can try to look at it. But maybe it is simpler for you to just debug it when having the car connected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgoderis kgoderis Awaiting requested review from kgoderis kgoderis will be requested when the pull request is marked ready for review kgoderis is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
additional testing preferred The change works for the pull request author. A test from someone else is preferred though. enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lsiepel @kaikreuzer