[airparif] New binding #17625

clinique · 2024-10-24T15:40:54Z

The AirParif binding provides data coming from Air Parif.
This service gives air quality and pollen information for Paris Area

clinique · 2024-11-20T16:38:55Z

This is ready to review now. If someone has some spare time... :-)

lsiepel

Thanks for this contribution. Reviewed all files. Don;t forget to run the i18n tool after all comments have been addressed. It already is in a good shape.

lsiepel · 2024-11-21T22:06:37Z

bundles/org.openhab.binding.airparif/README.md

+| aq-bulletin-tomorrow | pm10-max       | Number:Density | R          | Maximum level of PM 10 concentration         |
+| aq-bulletin-tomorrow | pm25-min       | Number:Density | R          | Minimum level of PM 2.5 concentration        |
+| aq-bulletin-tomorrow | pm25-max       | Number:Density | R          | Maximum level of PM 2.5 concentration        |
+| daily                | message        | String         | R          | Today's daily general information            ||| daily                | tomorrow       | String         | R          | Tomorrow's daily general information         |


Suggested change

| daily | message | String | R | Today's daily general information ||| daily | tomorrow | String | R | Tomorrow's daily general information |

| daily | message | String | R | Today's daily general information |

| daily | tomorrow | String | R | Tomorrow's daily general information |

lsiepel · 2024-11-21T22:08:43Z

bundles/org.openhab.binding.airparif/README.md

+| oh:airparif:urticaceae |   Yes   | ![](doc/images/urticaceae.svg) |
+| oh:airparif:willow     |   Yes   | ![](doc/images/willow.svg) |
+| oh:airparif:wormwood   |   Yes   | ![](doc/images/wormwood.svg) |
+


Suggested change

lsiepel · 2024-11-21T22:09:09Z

bundles/org.openhab.binding.airparif/README.md

+### Item Configurationn
+
+```java
+Example item configuration goes here.


Please extend with items file and optional sitemap file.

Items added.

lsiepel · 2024-11-21T22:09:26Z

bundles/org.openhab.binding.airparif/README.md

+
+```java
+Example item configuration goes here.
+``


Fix code close tag

lsiepel · 2024-11-21T22:13:32Z

...ing.airparif/src/main/java/org/openhab/binding/airparif/internal/AirParifHandlerFactory.java

+    @Activate
+    public AirParifHandlerFactory(final @Reference HttpClientFactory httpClientFactory,
+            final @Reference AirParifDeserializer deserializer) {
+        this.httpClient = httpClientFactory.getCommonHttpClient();


I think it is better to store the factory and each time a Handler is created you can grab the client from the factory

lsiepel · 2024-12-11T19:39:13Z

...parif/src/main/java/org/openhab/binding/airparif/internal/handler/AirParifBridgeHandler.java

+        updateState(new ChannelUID(pollensGroupUID, CHANNEL_COMMENT), Objects.requireNonNull(
+                localPollens.getComment().map(comment -> (State) new StringType(comment)).orElse(UnDefType.NULL)));
+        updateState(new ChannelUID(pollensGroupUID, CHANNEL_BEGIN_VALIDITY), Objects.requireNonNull(
+                localPollens.getBeginValidity().map(begin -> (State) new DateTimeType(begin)).orElse(UnDefType.NULL)));


The DateTimeType should be used with an Instant.
For reference: #17725

Changed all ZonedDateTimes to Instants

lsiepel · 2024-12-11T19:40:51Z

...nding.airparif/src/main/java/org/openhab/binding/airparif/internal/handler/HandlerUtils.java

+            operation = "Rescheduled";
+            cancelFuture(result);
+        }
+        getLogger().info("{} {} in {}", operation, jobName, duration);


Suggested change

getLogger().info("{} {} in {}", operation, jobName, duration);

getLogger().debug("{} {} in {}", operation, jobName, duration);

lsiepel · 2024-12-11T19:42:27Z

bundles/org.openhab.binding.airparif/src/main/resources/OH-INF/thing/channel-groups.xml

+	</channel-group-type>
+
+	<channel-group-type id="pollutant-mpc">
+		<label>Pollutant Concentration Information</label>


Suggested change

<label>Pollutant Concentration Information</label>

<label>Pollutant Concentration</label>

lsiepel · 2024-12-11T19:42:42Z

bundles/org.openhab.binding.airparif/src/main/resources/OH-INF/thing/channel-groups.xml

+	</channel-group-type>
+
+	<channel-group-type id="daily">
+		<label>Daily information for the region</label>


Suggested change

<label>Daily information for the region</label>

<label>Daily Region Information</label>

lsiepel · 2024-12-11T19:43:07Z

bundles/org.openhab.binding.airparif/src/main/resources/OH-INF/thing/channel-groups.xml

+	</channel-group-type>
+
+	<channel-group-type id="dept-pollens">
+		<label>Pollen information for the department</label>


Suggested change

<label>Pollen information for the department</label>

<label>Department Pollen Information</label>

bundles/org.openhab.binding.airparif/pom.xml

Signed-off-by: Gaël L'hopital <[email protected]>

Bulletproofed icon servlet Signed-off-by: Gaël L'hopital <[email protected]>

Signed-off-by: Gaël L'hopital <[email protected]>

Signed-off-by: clinique <[email protected]>

clinique added new binding If someone has started to work on a binding. For a new binding PR. work in progress A PR that is not yet ready to be merged labels Oct 24, 2024

clinique self-assigned this Oct 24, 2024

clinique requested a review from a team as a code owner October 24, 2024 15:40

clinique removed the work in progress A PR that is not yet ready to be merged label Nov 18, 2024

clinique requested review from lolodomo and lsiepel November 20, 2024 16:38

lsiepel requested changes Dec 11, 2024

View reviewed changes

wborn reviewed Dec 15, 2024

View reviewed changes

bundles/org.openhab.binding.airparif/pom.xml Outdated Show resolved Hide resolved

clinique added 15 commits December 16, 2024 10:51

Initial commit

1265419

Signed-off-by: Gaël L'hopital <[email protected]>

Progress done

4658292

Signed-off-by: Gaël L'hopital <[email protected]>

Remove doc file

272fb89

Signed-off-by: Gaël L'hopital <[email protected]>

Finalizing binding

dc1ac4d

Signed-off-by: Gaël L'hopital <[email protected]>

Added binding to pom.xml

3bd53b7

Signed-off-by: Gaël L'hopital <[email protected]>

SAT solving

838816c

Signed-off-by: Gaël L'hopital <[email protected]>

Solving nullable

ec0bb2f

Signed-off-by: Gaël L'hopital <[email protected]>

Placeholder corrected

8fcac57

Signed-off-by: Gaël L'hopital <[email protected]>

Adding Air Quality index

9aa3255

Signed-off-by: Gaël L'hopital <[email protected]>

Cleaning resource files

58ef294

Bulletproofed icon servlet Signed-off-by: Gaël L'hopital <[email protected]>

Activating discovery service

815de29

Signed-off-by: Gaël L'hopital <[email protected]>

Code cleansing

86458b1

Signed-off-by: Gaël L'hopital <[email protected]>

Written documentation and reviewed channels descriptions

02bf3c1

Signed-off-by: Gaël L'hopital <[email protected]>

Code review corrections

080f7a5

Signed-off-by: Gaël L'hopital <[email protected]>

POM update

3dc97e9

Signed-off-by: Gaël L'hopital <[email protected]>

clinique force-pushed the airparif branch from c26c091 to 3dc97e9 Compare December 16, 2024 09:57

clinique requested a review from lsiepel December 16, 2024 12:23

clinique added 2 commits January 9, 2025 15:52

Fix headers

da4c636

Signed-off-by: clinique <[email protected]>

Forgot to change the year

8e279a0

Signed-off-by: clinique <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[airparif] New binding #17625

[airparif] New binding #17625

clinique commented Oct 24, 2024 •

edited

Loading

clinique commented Nov 20, 2024

lsiepel left a comment

lsiepel Nov 21, 2024

clinique Dec 12, 2024

lsiepel Nov 21, 2024

clinique Dec 12, 2024

lsiepel Nov 21, 2024

clinique Dec 12, 2024

lsiepel Nov 21, 2024

clinique Dec 12, 2024

lsiepel Nov 21, 2024

clinique Dec 12, 2024

lsiepel Dec 11, 2024

clinique Dec 12, 2024

lsiepel Dec 11, 2024

clinique Dec 12, 2024

lsiepel Dec 11, 2024

clinique Dec 16, 2024

lsiepel Dec 11, 2024

clinique Dec 12, 2024

lsiepel Dec 11, 2024

clinique Dec 12, 2024

	\| daily \| message \| String \| R \| Today's daily general information \|\|\| daily \| tomorrow \| String \| R \| Tomorrow's daily general information \|
	\| daily \| message \| String \| R \| Today's daily general information \|
	\| daily \| tomorrow \| String \| R \| Tomorrow's daily general information \|

	getLogger().info("{} {} in {}", operation, jobName, duration);
	getLogger().debug("{} {} in {}", operation, jobName, duration);

	<label>Pollutant Concentration Information</label>
	<label>Pollutant Concentration</label>

	<label>Daily information for the region</label>
	<label>Daily Region Information</label>

	<label>Pollen information for the department</label>
	<label>Department Pollen Information</label>

[airparif] New binding #17625

Are you sure you want to change the base?

[airparif] New binding #17625

Conversation

clinique commented Oct 24, 2024 • edited Loading

clinique commented Nov 20, 2024

lsiepel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

clinique commented Oct 24, 2024 •

edited

Loading