[lutron] Added device discovery for DivaSmartDimmer and PaddleSwitchPico #17723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsjames
added
the
enhancement
lsiepel
reviewed
Nov 10, 2024
| @@ -118,7 +120,7 @@ public void processDeviceDefinitions(List<Device> deviceList) { | |||
| // Don't discover sensors. Using occupancy groups instead. | |||
| break; | |||
| default: | |||
| logger.info("Unrecognized device type: {}", device.deviceType); | |||
| logger.info("Unrecognized device type: {} ({})", device.deviceType, deviceId); | |||
There was a problem hiding this comment.
Suggested change
| logger.info("Unrecognized device type: {} ({})", device.deviceType, deviceId); | |
| logger.info("Unrecognized device type: {} id: ({})", device.deviceType, deviceId); |
…l not print out ID of any unrecongnized device in the logs. Signed-off-by: Jeff James <[email protected]>
Signed-off-by: Jeff James <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[lutron] Added device discovery for DivaSmartDimmer and PaddleSwitchPico
Description
Added discovery of DivaSmartDimmer and PaddleSwitchPico device types and mapped to creation of appropriate device.
Also, added the deviceId to the "Unrecognized" device log so that users can manually add new devices in the future.