Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tibber] Add price_level to today_prices and tomorrow_prices #17916

Merged
merged 1 commit into from
Dec 18, 2024
Merged

[tibber] Add price_level to today_prices and tomorrow_prices #17916

merged 1 commit into from
Dec 18, 2024

Conversation

tomquist
Copy link
Contributor

Description

This PR implements the feature request from issue #17915.
The Tibber Binding's today_prices and tomorrow_prices JSON arrays now include the level field, which provides price level information (e.g., "EXPENSIVE", "NORMAL", "CHEAP") for each price entry.

@tomquist tomquist requested a review from kjoglum as a code owner December 17, 2024 11:30
@jlaur jlaur linked an issue Dec 17, 2024 that may be closed by this pull request
[Tibber] Add price_level to today_prices and tomorrow_prices channels #17915
Closed
@jlaur jlaur added the enhancement An enhancement or new feature for an existing add-on label Dec 17, 2024
lsiepel
lsiepel requested changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also adapt the documentation, otherwise LGTM.

lsiepel
lsiepel approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@lsiepel lsiepel merged commit f78c618 into openhab:main Dec 18, 2024
3 checks passed
@lsiepel lsiepel added this to the 5.0 milestone Dec 18, 2024
@tomquist tomquist deleted the patch-1 branch December 18, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsiepel lsiepel lsiepel approved these changes

@kjoglum kjoglum Awaiting requested review from kjoglum kjoglum is a code owner

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

[Tibber] Add price_level to today_prices and tomorrow_prices channels
3 participants
@tomquist @lsiepel @jlaur