Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[roku] Check for ECP Limited Mode #17925

Merged
merged 2 commits into from
Dec 19, 2024
Merged

[roku] Check for ECP Limited Mode #17925

merged 2 commits into from
Dec 19, 2024

Conversation

mlobstein
Copy link
Contributor

Very recently Roku has pushed out new firmware that blocks external control commands by default. This PR adds code to detect when the Roku is configured incorrectly and notifies the user via the Thing status description message about how to correct the problem.

Signed-off-by: Michael Lobstein <[email protected]>
@mlobstein mlobstein added the enhancement An enhancement or new feature for an existing add-on label Dec 18, 2024
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/roku-firmware-update-requires-configuration-change/160938/1

Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Only one minor suggestion.

Signed-off-by: Michael Lobstein <[email protected]>
Copy link
Contributor

@morph166955 morph166955 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. My TVs haven't updated yet so I don't have a way to test. Code looks good though.

Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlaur jlaur merged commit 5d40a71 into openhab:main Dec 19, 2024
3 checks passed
@jlaur jlaur added this to the 5.0 milestone Dec 19, 2024
@mlobstein mlobstein deleted the roku_limited branch December 19, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants