Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xmpp] Add action for sending a group message #17938

Merged
merged 2 commits into from
Dec 31, 2024

Conversation

akallabeth
Copy link
Contributor

my take on getting group messages to work.

did avoid updating smack (don´t know what that would trigger) and simply added a new function to be called

@lsiepel lsiepel added the enhancement An enhancement or new feature for an existing add-on label Dec 20, 2024
@akallabeth akallabeth marked this pull request as ready for review December 20, 2024 21:37
@lsiepel lsiepel linked an issue Dec 20, 2024 that may be closed by this pull request
@akallabeth
Copy link
Contributor Author

ok, did have a bug with not properly joining the group chat, but now it is working nicely on my local installation.

@akallabeth
Copy link
Contributor Author

added optional setting of nickname for group chat as well now.

Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution. Just one comment.

@lsiepel lsiepel changed the title [xmpp] implement group message sending [xmpp] Add action for sending a group message Dec 21, 2024
@akallabeth
Copy link
Contributor Author

@lsiepel how can the ci be retriggered? looks like a glitch in the last run.

@lsiepel lsiepel added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Dec 23, 2024
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@lsiepel lsiepel merged commit d4cbc5f into openhab:main Dec 31, 2024
3 checks passed
@lsiepel lsiepel added this to the 5.0 milestone Dec 31, 2024
@akallabeth akallabeth deleted the xmpp-group branch January 1, 2025 11:48
DrRSatzteil pushed a commit to DrRSatzteil/openhab-addons that referenced this pull request Jan 3, 2025
* implement group message sending

Signed-off-by: akallabeth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[xmppclient] Sending XMPP groupchat messages to room
2 participants