-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[xmpp] Add action for sending a group message #17938
Conversation
61358e0
to
9b282b2
Compare
9b282b2
to
869fcbf
Compare
Signed-off-by: akallabeth <[email protected]>
869fcbf
to
0a41a0e
Compare
ok, did have a bug with not properly joining the group chat, but now it is working nicely on my local installation. |
added optional setting of nickname for group chat as well now. |
8f38009
to
fe3f505
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this contribution. Just one comment.
...ding.xmppclient/src/main/java/org/openhab/binding/xmppclient/internal/client/XMPPClient.java
Outdated
Show resolved
Hide resolved
Signed-off-by: akallabeth <[email protected]>
fe3f505
to
349db58
Compare
@lsiepel how can the ci be retriggered? looks like a glitch in the last run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
* implement group message sending Signed-off-by: akallabeth <[email protected]>
my take on getting group messages to work.
did avoid updating smack (don´t know what that would trigger) and simply added a new function to be called