Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pihole] Fix enableBlocking action #17967

Merged
merged 1 commit into from
Dec 24, 2024
Merged

Conversation

sgiehl
Copy link
Contributor

@sgiehl sgiehl commented Dec 23, 2024

The pihole thing action enableBlocking currently uses the wrong API endpoint and therefor disables the blocking instead of enabling it.

fixes #17966

@sgiehl sgiehl added the bug An unexpected problem or unintended behavior of an add-on label Dec 23, 2024
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@lsiepel lsiepel changed the title [pihole] fix enableBlocking action [pihole] Fix enableBlocking action Dec 24, 2024
@lsiepel lsiepel merged commit 7e99669 into openhab:main Dec 24, 2024
3 checks passed
@lsiepel lsiepel added this to the 5.0 milestone Dec 24, 2024
lsiepel pushed a commit that referenced this pull request Dec 24, 2024
@lsiepel lsiepel added the patch A PR that has been cherry-picked to a patch release branch label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pihole] enableBlocking action does not work correctly
2 participants