Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mqtt.generic] Fix ClassCastException when receiving ON/OFF on a dimmer channel #17980

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Dec 25, 2024

A dimmer channel used to be able to receive ON / OFF through MQTT in openHAB 4.2. This broke in 4.3.

Reported here: https://community.openhab.org/t/openhab-4-3-release-discussion/160888/192

This needs to be backported to 4.3.x

Fixes #17968

@jimtng jimtng requested a review from ccutrer as a code owner December 25, 2024 14:31
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openhab-4-3-release-discussion/160888/202

@jlaur jlaur added the bug An unexpected problem or unintended behavior of an add-on label Dec 25, 2024
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quickly fixing this! Is it related to #15929?

@jlaur jlaur merged commit d049995 into openhab:main Dec 25, 2024
3 checks passed
@jlaur jlaur added this to the 5.0 milestone Dec 25, 2024
jlaur pushed a commit that referenced this pull request Dec 25, 2024
@jlaur jlaur added the patch A PR that has been cherry-picked to a patch release branch label Dec 25, 2024
@jlaur jlaur changed the title [mqtt.generic] Fix ClassCastException when receiving ON/OFF on a dimmer channel [mqtt.generic] Fix ClassCastException when receiving ON/OFF on a dimmer channel Dec 25, 2024
@jimtng
Copy link
Contributor Author

jimtng commented Dec 25, 2024

Thanks for quickly fixing this! Is it related to #15929?

Yes it is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MQTT] dimmer channel throws error when receiving ON or OFF
3 participants