Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tesla] Fix NumberFormatException #17983

Merged
merged 1 commit into from
Dec 25, 2024
Merged

[tesla] Fix NumberFormatException #17983

merged 1 commit into from
Dec 25, 2024

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Dec 25, 2024

Fix NumberFormatException reported here: https://community.openhab.org/t/tesla-binding-exception-occurred-while-parsing-data/161012/5

Test jar should be usable in 4.3.0: https://1drv.ms/u/s!AnMcxmvEeupwj49RabXgS_bRX-8P4Q?e=dVZurL

Should be backported when confirmed as fix.

@lsiepel
Fix NumberFormatException
bee137d 
Signed-off-by: Leo Siepel <[email protected]>
@lsiepel lsiepel added bug An unexpected problem or unintended behavior of an add-on additional testing preferred The change works for the pull request author. A test from someone else is preferred though. regression Regression that happened during the development of a release. Not shown on final release notes. labels Dec 25, 2024
@lsiepel lsiepel requested a review from kgoderis as a code owner December 25, 2024 21:58
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/tesla-binding-exception-occurred-while-parsing-data/161012/11

@mtraxiot
Copy link
Contributor

linked to report #17984

@mtraxiot
Copy link
Contributor

confirmed fixed for me.

@jlaur jlaur removed the regression Regression that happened during the development of a release. Not shown on final release notes. label Dec 25, 2024
@jlaur jlaur linked an issue Dec 25, 2024 that may be closed by this pull request
[Tesla] An exception occurred while parsing data received from the vehicle #17984
Closed
@jlaur
Copy link
Contributor

jlaur commented Dec 25, 2024

Most likely regression of #17582.

jlaur
jlaur approved these changes Dec 25, 2024
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@jlaur jlaur merged commit 1e7d01c into openhab:main Dec 25, 2024
3 checks passed
@jlaur jlaur removed the additional testing preferred The change works for the pull request author. A test from someone else is preferred though. label Dec 25, 2024
@jlaur jlaur added this to the 5.0 milestone Dec 25, 2024
jlaur pushed a commit that referenced this pull request Dec 25, 2024
@lsiepel @jlaur
Fix NumberFormatException (#17983)
5f64b85 
Signed-off-by: Leo Siepel <[email protected]>
@jlaur jlaur added the patch A PR that has been cherry-picked to a patch release branch label Dec 25, 2024
@lsiepel lsiepel deleted the tesla-numberformatexception branch December 26, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur approved these changes

@kgoderis kgoderis Awaiting requested review from kgoderis kgoderis is a code owner

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

[Tesla] An exception occurred while parsing data received from the vehicle
4 participants
@lsiepel @openhab-bot @mtraxiot @jlaur