Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[insteon] Add led brightness on level channel parameter #17987

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

jsetton
Copy link
Contributor

@jsetton jsetton commented Dec 26, 2024

This change adds a channel parameter to set the LED brightness level to use when an ON command is received. It now defaults to 50% in line with standard behavior.

This also includes removing OnOffType command support for the on-level channel since it should only be set to a percent value.

@jlaur jlaur added the enhancement An enhancement or new feature for an existing add-on label Dec 26, 2024
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks, LGTM.

@jlaur jlaur merged commit 24f4fc3 into openhab:main Dec 26, 2024
3 checks passed
@jlaur jlaur added this to the 5.0 milestone Dec 26, 2024
@jsetton jsetton deleted the insteon-led-on-level branch December 26, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants