Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jrubyscripting] Minor updates, add short examples at the top of README.md #18030

Merged
merged 3 commits into from
Jan 9, 2025
Merged

[jrubyscripting] Minor updates, add short examples at the top of README.md #18030

merged 3 commits into from
Jan 9, 2025

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Jan 4, 2025

Make it easier to see examples of rules written in JRuby

@jimtng jimtng requested a review from ccutrer as a code owner January 4, 2025 02:14
jlaur
jlaur reviewed Jan 4, 2025
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the documentation! I have only some minor comments.

bundles/org.openhab.automation.jrubyscripting/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.automation.jrubyscripting/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.automation.jrubyscripting/README.md Show resolved Hide resolved
jimtng added 2 commits January 5, 2025 08:40
@jimtng
Rules DSL, table formatting
3327261 
Signed-off-by: Jimmy Tanagra <[email protected]>
@jimtng
remove note for openhab 3.4
ad499a5 
Signed-off-by: Jimmy Tanagra <[email protected]>
jlaur
jlaur approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlaur jlaur merged commit a1fc363 into openhab:main Jan 9, 2025
2 checks passed
@jlaur jlaur added this to the 5.0 milestone Jan 9, 2025
@jimtng jimtng deleted the jruby-readme branch January 9, 2025 23:55
GearrelW pushed a commit to GearrelW/openhab-addons that referenced this pull request Jan 12, 2025
@jimtng @GearrelW
[jrubyscripting] Minor updates, add short examples at the top of READ…
de2db6e 
…ME.md (openhab#18030)

Signed-off-by: Jimmy Tanagra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur approved these changes

@ccutrer ccutrer ccutrer approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jimtng @ccutrer @jlaur @lsiepel