-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[network] Make icmp ping and arp ping optional by presence thing #18083
Conversation
Signed-off-by: Mark Herwege <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks! Two comments, otherwise LGTM. And thanks for bringing my attention to NetworkUtils
, this helped me reassure my approach in #18082. 😄
....binding.network/src/main/java/org/openhab/binding/network/internal/utils/LatencyParser.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.network/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Mark Herwege <[email protected]>
@jlaur Thanks for the feedback. I have done the requested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found a few more things to update after renaming the ICMP ping parameter.
bundles/org.openhab.binding.network/src/main/resources/OH-INF/i18n/network.properties
Outdated
Show resolved
Hide resolved
Signed-off-by: Mark Herwege <[email protected]>
Adjustments done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…nhab#18083) Signed-off-by: Mark Herwege <[email protected]>
I was trying to use the Network binding to create a ping reply log to my router. It turned out to be hard to get a good result. While the presence thing has been optimized for presence detection, it does not allow good and comparable ping latency tracking.
The issues I ran into:
A workaround was to use an IPv6 destination address, as that would exclude ARP ping, but it is still only a workaround.
This PR does: