Readd openhab get all items retry logic (#408)

Signed-off-by: jsetton <[email protected]>
openhab · Nov 10, 2021 · 893aa30 · 893aa30
1 parent 13ae3ae
commit 893aa30
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/lambda/openhab/index.js b/lambda/openhab/index.js
@@ -56,7 +56,11 @@ class OpenHAB {
    * @return {Promise}
    */
   async getAllItems() {
-    const items = await this.getItems();
+    let items;
+    // Retrieve all items up to 3 tries if not an array
+    for (let tries = 0; !Array.isArray(items) && tries < 3; tries++) {
+      items = await this.getItems();
+    }
     // Return all items adding members and expanding groupNames into groups
     return items.map(({ groupNames, ...item }) => ({
       ...item,

diff --git a/lambda/test/openhab.test.js b/lambda/test/openhab.test.js
@@ -231,7 +231,16 @@ describe('OpenHAB Tests', () => {
 
     it('type error', async () => {
       // set environment
-      nock(baseURL).get('/rest/items').query(qs).reply(200, 'invalid');
+      nock(baseURL)
+        .get('/rest/items')
+        .query(qs)
+        .reply(200, 'invalid 1')
+        .get('/rest/items')
+        .query(qs)
+        .reply(200, 'invalid 2')
+        .get('/rest/items')
+        .query(qs)
+        .reply(200, 'invalid 3');
       // run test
       try {
         await openhab.getAllItems();